Sign upLogin

department-of-veterans-affairs/vets-website

View on GitHub
Star
src/applications/gi/components/profile/InstitutionProfile.jsx

Summary

Maintainability
A
3 hrs
Test Coverage

Function InstitutionProfile has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

export default function InstitutionProfile({
  institution,
  isOJT,
  constants,
  showModal,
Severity: Minor
Found in src/applications/gi/components/profile/InstitutionProfile.jsx - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 13 locations. Consider refactoring.
Open

export default function InstitutionProfile({
  institution,
  isOJT,
  constants,
  showModal,
Severity: Major
Found in src/applications/gi/components/profile/InstitutionProfile.jsx and 12 other locations - About 55 mins to fix
src/applications/appeals/996/containers/Form0996App.jsx on lines 36..195
src/applications/find-forms/containers/SearchResults.jsx on lines 43..264
src/applications/gi/containers/FilterYourResults.jsx on lines 70..485
src/applications/income-limits/containers/ReviewPage.jsx on lines 18..190
src/applications/ivc-champva/shared/components/fileUploads/MissingFileList.jsx on lines 118..182
src/applications/my-education-benefits/components/HowToApplyPost911GiBillV2.jsx on lines 11..70
src/applications/personalization/profile/components/direct-deposit/vye/components/SuggestedAddress.jsx on lines 19..186
src/applications/personalization/profile/components/notification-settings/NotificationCheckbox.jsx on lines 7..116
src/applications/representative-search/components/results/ReportModal.jsx on lines 10..184
src/applications/verify-your-enrollment/components/SuggestedAddress.jsx on lines 20..182
src/platform/forms-system/src/js/components/FormSignature.jsx on lines 31..140
src/platform/forms-system/src/js/patterns/array-builder/ArrayBuilderCancelButton.jsx on lines 36..150

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      {!isOJT && (
        <ProfileSection
          label="Veteran programs and support"
          id="veteran-programs-and-support"
        >
Severity: Minor
Found in src/applications/gi/components/profile/InstitutionProfile.jsx and 1 other location - About 50 mins to fix
src/applications/gi/components/vet-tec/InstitutionProfile.jsx on lines 74..85

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 52.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

      {showSchoolContentBasedOnType(type) &&
        type !== 'FOREIGN' && (
          <ProfileSection
            label="Calculate your benefits"
            id="calculate-your-benefits"
Severity: Minor
Found in src/applications/gi/components/profile/InstitutionProfile.jsx and 2 other locations - About 30 mins to fix
src/applications/gi/components/profile/InstitutionProfile.jsx on lines 223..227
src/applications/rated-disabilities/components/RatedDisabilityList.jsx on lines 123..127

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

      {!isOJT && (
        <ProfileSection label="Academics" id="academics">
          <Academics institution={institution} onShowModal={showModal} />
        </ProfileSection>
      )}
Severity: Minor
Found in src/applications/gi/components/profile/InstitutionProfile.jsx and 2 other locations - About 30 mins to fix
src/applications/gi/components/profile/InstitutionProfile.jsx on lines 154..165
src/applications/rated-disabilities/components/RatedDisabilityList.jsx on lines 123..127

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status