department-of-veterans-affairs/vets-website

View on GitHub
src/applications/gi/containers/FilterYourResults.jsx

Summary

Maintainability
F
4 days
Test Coverage

File FilterYourResults.jsx has 465 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import React, { useState } from 'react';
import { useHistory } from 'react-router-dom';
import { connect } from 'react-redux';
import _ from 'lodash';
import recordEvent from 'platform/monitoring/record-event';
Severity: Minor
Found in src/applications/gi/containers/FilterYourResults.jsx - About 7 hrs to fix

    Function specializedMissionAttributes has 64 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      const specializedMissionAttributes = () => {
        const options = [
          {
            name: 'specialMissionHbcu',
            checked: specialMissionHbcu,
    Severity: Major
    Found in src/applications/gi/containers/FilterYourResults.jsx - About 2 hrs to fix

      Function FilterYourResults has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

      export function FilterYourResults({
        dispatchFilterChange,
        dispatchError,
        filters,
        modalClose,
      Severity: Minor
      Found in src/applications/gi/containers/FilterYourResults.jsx - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function schoolAttributes has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        const schoolAttributes = () => {
          const options = [
            {
              name: 'excludeCautionFlags',
              checked: excludeCautionFlags,
      Severity: Minor
      Found in src/applications/gi/containers/FilterYourResults.jsx - About 1 hr to fix

        Function vetTecCheckbox has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        const vetTecCheckbox = (
          vettec,
          preferredProvider,
          handleVetTecChange,
          handlePreferredProviderChange,
        Severity: Minor
        Found in src/applications/gi/containers/FilterYourResults.jsx - About 1 hr to fix

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

            const renderStateFilter = () => {
              const options = Object.keys(facets.state)
                .map(facetState => ({
                  optionValue: facetState,
                  optionLabel: getStateNameForCode(facetState),
          Severity: Major
          Found in src/applications/gi/containers/FilterYourResults.jsx and 2 other locations - About 4 hrs to fix
          src/applications/gi/containers/search/FilterBeforeResults.jsx on lines 713..731
          src/applications/gi/containers/search/FilterByLocation.jsx on lines 76..94

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 118.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            const {
              expanded,
              excludedSchoolTypes,
              excludeCautionFlags,
              accredited,
          Severity: Major
          Found in src/applications/gi/containers/FilterYourResults.jsx and 1 other location - About 3 hrs to fix
          src/applications/representative-search/components/results/SearchResult.jsx on lines 15..37

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 107.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

            const renderCountryFilter = () => {
              const options = facets.country.map(facetCountry => ({
                optionValue: facetCountry.name,
                optionLabel: facetCountry.name,
              }));
          Severity: Major
          Found in src/applications/gi/containers/FilterYourResults.jsx and 2 other locations - About 3 hrs to fix
          src/applications/gi/containers/search/FilterBeforeResults.jsx on lines 733..750
          src/applications/gi/containers/search/FilterByLocation.jsx on lines 57..74

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 106.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              const options = INSTITUTION_TYPES.map(type => {
                return {
                  name: type.toUpperCase(),
                  checked: excludedSchoolTypes.includes(type.toUpperCase()),
                  optionLabel: INSTITUTION_TYPES_DICTIONARY[type],
          Severity: Major
          Found in src/applications/gi/containers/FilterYourResults.jsx and 1 other location - About 2 hrs to fix
          src/applications/gi/containers/search/FilterBeforeResults.jsx on lines 490..497

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 79.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                    <div>
                      <h1>Filter your results</h1>
                      {search.inProgress && (
                        <VaLoadingIndicator
                          data-testid="loading-indicator"
          Severity: Major
          Found in src/applications/gi/containers/FilterYourResults.jsx and 1 other location - About 1 hr to fix
          src/applications/gi/containers/search/FilterBeforeResults.jsx on lines 861..870

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 67.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 13 locations. Consider refactoring.
          Open

          export function FilterYourResults({
            dispatchFilterChange,
            dispatchError,
            filters,
            modalClose,
          Severity: Major
          Found in src/applications/gi/containers/FilterYourResults.jsx and 12 other locations - About 55 mins to fix
          src/applications/appeals/996/containers/Form0996App.jsx on lines 36..195
          src/applications/find-forms/containers/SearchResults.jsx on lines 43..264
          src/applications/gi/components/profile/InstitutionProfile.jsx on lines 27..251
          src/applications/income-limits/containers/ReviewPage.jsx on lines 18..190
          src/applications/ivc-champva/shared/components/fileUploads/MissingFileList.jsx on lines 118..182
          src/applications/my-education-benefits/components/HowToApplyPost911GiBillV2.jsx on lines 11..70
          src/applications/personalization/profile/components/direct-deposit/vye/components/SuggestedAddress.jsx on lines 19..186
          src/applications/personalization/profile/components/notification-settings/NotificationCheckbox.jsx on lines 7..116
          src/applications/representative-search/components/results/ReportModal.jsx on lines 10..184
          src/applications/verify-your-enrollment/components/SuggestedAddress.jsx on lines 20..182
          src/platform/forms-system/src/js/components/FormSignature.jsx on lines 31..140
          src/platform/forms-system/src/js/patterns/array-builder/ArrayBuilderCancelButton.jsx on lines 36..150

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 53.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

            const recordCheckboxEvent = e => {
              recordEvent({
                event: 'gibct-form-change',
                'gibct-form-field': e.target.name,
                'gibct-form-value': e.target.checked,
          Severity: Major
          Found in src/applications/gi/containers/FilterYourResults.jsx and 2 other locations - About 50 mins to fix
          src/applications/gi/containers/search/FilterBeforeResults.jsx on lines 384..390
          src/applications/gi/containers/search/FilterBeforeResults.jsx on lines 392..398

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 52.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      <button
                        type="button"
                        id={`update-${createId(title)}-button`}
                        className="update-results-button"
                        onClick={closeAndUpdate}
          Severity: Minor
          Found in src/applications/gi/containers/FilterYourResults.jsx and 1 other location - About 40 mins to fix
          src/applications/gi/containers/search/FilterBeforeResults.jsx on lines 779..786

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 49.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          const mapStateToProps = state => ({
            filters: state.filters,
            search: state.search,
            preview: state.preview,
            errorReducer: state.errorReducer,
          Severity: Minor
          Found in src/applications/gi/containers/FilterYourResults.jsx and 1 other location - About 40 mins to fix
          src/applications/gi/containers/search/FilterBeforeResults.jsx on lines 877..882

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 48.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status