department-of-veterans-affairs/vets-website

View on GitHub
src/applications/gi/containers/NationalExamsList.jsx

Summary

Maintainability
C
1 day
Test Coverage

Function NationalExamsList has 188 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const NationalExamsList = () => {
  const dispatch = useDispatch();
  const [currentPage, setCurrentPage] = useState(1);
  const itemsPerPage = 5;
  const { loading, error, nationalExams } = useSelector(
Severity: Major
Found in src/applications/gi/containers/NationalExamsList.jsx - About 7 hrs to fix

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

                    <va-table-row slot="headers">
                      <span className="table-header">Fee Description</span>
                      <span className="table-header">Dates</span>
                      <span className="table-header">Amount</span>
                    </va-table-row>
    Severity: Major
    Found in src/applications/gi/containers/NationalExamsList.jsx and 2 other locations - About 1 hr to fix
    src/applications/ds-playground/pages/V1V3Page.jsx on lines 838..842
    src/applications/financial-status-report/components/household/DependentAges.jsx on lines 197..206

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 71.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                    <span className="vads-u-display--flex vads-u-align-items--center">
                      <va-icon icon="public" size={3} />
                      <span>{exam.institution.webAddress}</span>
                    </span>
    Severity: Major
    Found in src/applications/gi/containers/NationalExamsList.jsx and 1 other location - About 1 hr to fix
    src/applications/gi/containers/NationalExamsList.jsx on lines 161..164

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 60.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                    <span className="vads-u-display--flex vads-u-align-items--center vads-u-margin-bottom--1">
                      <va-icon icon="location_city" size={3} />
                      <span>{exam.institution.name}</span>
                    </span>
    Severity: Major
    Found in src/applications/gi/containers/NationalExamsList.jsx and 1 other location - About 1 hr to fix
    src/applications/gi/containers/NationalExamsList.jsx on lines 165..168

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 60.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 17 locations. Consider refactoring.
    Open

                    <div className="vads-u-margin-bottom--3">
                      <a
                        href="https://www.va.gov/find-forms/about-form-22-0810/"
                        target="_blank"
                        rel="noopener noreferrer"
    Severity: Major
    Found in src/applications/gi/containers/NationalExamsList.jsx and 16 other locations - About 30 mins to fix
    src/applications/appeals/testing/nod-new/components/ContactInformation.jsx on lines 40..48
    src/applications/appeals/testing/nod-new/components/ContactInformation.jsx on lines 58..66
    src/applications/appeals/testing/nod-new/components/ContactInformation.jsx on lines 73..81
    src/applications/appeals/testing/nod-new/components/ContactInformation.jsx on lines 94..102
    src/applications/caregivers/components/IntroductionPage/ProcessTimeline.jsx on lines 50..58
    src/applications/disability-benefits/all-claims/content/toxicExposure.jsx on lines 28..36
    src/applications/ds-playground/pages/V1V3Page.jsx on lines 719..727
    src/applications/financial-status-report/components/contactInfo/ContactInfo.jsx on lines 138..146
    src/applications/financial-status-report/components/contactInfo/ContactInfo.jsx on lines 151..159
    src/applications/financial-status-report/components/contactInfo/ContactInfo.jsx on lines 166..174
    src/applications/pensions/components/FormAlerts/index.jsx on lines 234..246
    src/applications/search/components/SearchMaintenance.jsx on lines 59..68
    src/applications/simple-forms/21-4138/config/constants.js on lines 182..190
    src/applications/simple-forms/21-4138/config/constants.js on lines 209..217
    src/applications/simple-forms/21-4138/config/constants.js on lines 254..263
    src/applications/simple-forms/21-4138/config/constants.js on lines 296..304

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status