Sign upLogin

department-of-veterans-affairs/vets-website

View on GitHub
Star
src/applications/ivc-champva/shared/components/fileUploads/MissingFileOverview.jsx

Summary

Maintainability
D
2 days
Test Coverage

File MissingFileOverview.jsx has 356 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*
OVERVIEW:
The MissingFileOverview component is responsible for tracking file uploads
within the form and displaying a message to the user indicating which files
they have yet to upload before the application is considered complete.
Severity: Minor
Found in src/applications/ivc-champva/shared/components/fileUploads/MissingFileOverview.jsx - About 4 hrs to fix

    Function MissingFileOverview has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
    Open

    export default function MissingFileOverview({
  contentAfterButtons,
  data,
  goBack,
  goForward,
    Severity: Minor
    Found in src/applications/ivc-champva/shared/components/fileUploads/MissingFileOverview.jsx - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function mailInfo has 47 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    const mailInfo = (address, officeName, faxNum, preamble, appType) => {
  const faxNumMarkup = (
    <VaTelephone
      contact={JSON.stringify({
        phoneNumber: faxNum ?? '3033317809',
    Severity: Minor
    Found in src/applications/ivc-champva/shared/components/fileUploads/MissingFileOverview.jsx - About 1 hr to fix

      Function checkFlags has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export function checkFlags(pages, person, newListOfMissingFiles) {
  const personUpdated = person; // shallow, updates reflect on actual form state
  const wrapped = Array.isArray(pages)
    ? pages
    : Object.keys(pages).map(pg => pages[pg]); // On confirmation, "pages" is obj
      Severity: Minor
      Found in src/applications/ivc-champva/shared/components/fileUploads/MissingFileOverview.jsx - About 1 hr to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

          form: PropTypes.shape({
    pages: PropTypes.object,
    data: PropTypes.shape({
      applicants: PropTypes.array,
      statementOfTruthSignature: PropTypes.string,
        Severity: Major
        Found in src/applications/ivc-champva/shared/components/fileUploads/MissingFileOverview.jsx and 1 other location - About 5 hrs to fix
        src/applications/ivc-champva/shared/constants.js on lines 4..21

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 152.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        export default function MissingFileOverview({
  contentAfterButtons,
  data,
  goBack,
  goForward,
        Severity: Major
        Found in src/applications/ivc-champva/shared/components/fileUploads/MissingFileOverview.jsx and 1 other location - About 4 hrs to fix
        src/applications/vaos/appointment-list/redux/selectors.js on lines 770..795

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 121.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status