Sign upLogin

department-of-veterans-affairs/vets-website

View on GitHub
Star
src/applications/letters/containers/LetterList.jsx

Summary

Maintainability
C
7 hrs
Test Coverage

Function render has 129 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  render() {
    const downloadStatus = this.props.letterDownloadStatus;
    const letterItems = (this.props.letters || []).map((letter, index) => {
      let content;
      let letterTitle;
Severity: Major
Found in src/applications/letters/containers/LetterList.jsx - About 5 hrs to fix

    Function letterItems has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        const letterItems = (this.props.letters || []).map((letter, index) => {
      let content;
      let letterTitle;
      let helpText;
      if (letter.letterType === LETTER_TYPES.benefitSummary) {
    Severity: Minor
    Found in src/applications/letters/containers/LetterList.jsx - About 1 hr to fix

      Function render has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

        render() {
    const downloadStatus = this.props.letterDownloadStatus;
    const letterItems = (this.props.letters || []).map((letter, index) => {
      let content;
      let letterTitle;
      Severity: Minor
      Found in src/applications/letters/containers/LetterList.jsx - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status