Sign upLogin

department-of-veterans-affairs/vets-website

View on GitHub
Star
src/applications/letters/utils/helpers.jsx

Summary

Maintainability
D
2 days
Test Coverage

File helpers.jsx has 399 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/* eslint-disable camelcase */
import React from 'react';

import EbenefitsLink from 'platform/site-wide/ebenefits/containers/EbenefitsLink';
import { apiRequest as commonApiClient } from '@department-of-veterans-affairs/platform-utilities/api';
Severity: Minor
Found in src/applications/letters/utils/helpers.jsx - About 5 hrs to fix

    Function getBenefitOptionText has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export function getBenefitOptionText(
  option,
  value,
  isVeteran,
  awardEffectiveDate,
    Severity: Minor
    Found in src/applications/letters/utils/helpers.jsx - About 1 hr to fix

      Function getBenefitOptionText has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      export function getBenefitOptionText(
  option,
  value,
  isVeteran,
  awardEffectiveDate,
      Severity: Minor
      Found in src/applications/letters/utils/helpers.jsx - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          false: {
      veteran: (
        <div>
          You <strong>aren’t</strong> considered to be totally and permanently
          disabled solely due to your service-connected disabilities.
      Severity: Major
      Found in src/applications/letters/utils/helpers.jsx and 1 other location - About 1 hr to fix
      src/applications/letters/utils/helpers.jsx on lines 262..274

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 64.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          true: {
      veteran: (
        <div>
          You <strong>are</strong> considered to be totally and permanently
          disabled solely due to your service-connected disabilities.
      Severity: Major
      Found in src/applications/letters/utils/helpers.jsx and 1 other location - About 1 hr to fix
      src/applications/letters/utils/helpers.jsx on lines 275..287

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 64.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

        hasNonServiceConnectedPension: {
    true: {
      veteran: (
        <div>
          You <strong>are</strong> receiving non-service connected pension.
      Severity: Major
      Found in src/applications/letters/utils/helpers.jsx and 2 other locations - About 1 hr to fix
      src/applications/letters/utils/helpers.jsx on lines 246..260
      src/applications/letters/utils/helpers.jsx on lines 308..322

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 62.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

        hasAdaptedHousing: {
    true: {
      veteran: (
        <div>
          You <strong>qualify</strong> for a Specially Adapted Housing (SAH)
      Severity: Major
      Found in src/applications/letters/utils/helpers.jsx and 2 other locations - About 1 hr to fix
      src/applications/letters/utils/helpers.jsx on lines 184..197
      src/applications/letters/utils/helpers.jsx on lines 308..322

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 62.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

        hasIndividualUnemployabilityGranted: {
    true: {
      veteran: (
        <div>
          You <strong>are</strong> being paid at 100% because you’re
      Severity: Major
      Found in src/applications/letters/utils/helpers.jsx and 2 other locations - About 1 hr to fix
      src/applications/letters/utils/helpers.jsx on lines 184..197
      src/applications/letters/utils/helpers.jsx on lines 246..260

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 62.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        hasSurvivorsPensionAward: {
    true: {
      veteran: undefined,
      dependent: (
        <div>
      Severity: Major
      Found in src/applications/letters/utils/helpers.jsx and 1 other location - About 1 hr to fix
      src/applications/letters/utils/helpers.jsx on lines 217..231

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 62.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        hasSurvivorsIndemnityCompensationAward: {
    true: {
      veteran: undefined,
      dependent: (
        <div>
      Severity: Major
      Found in src/applications/letters/utils/helpers.jsx and 1 other location - About 1 hr to fix
      src/applications/letters/utils/helpers.jsx on lines 232..245

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 62.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

        <div>
    <p>
      If your service period or disability status information is incorrect,
      please send us a message through
      <a target="_blank" rel="noopener noreferrer" href="https://ask.va.gov/">
      Severity: Major
      Found in src/applications/letters/utils/helpers.jsx and 4 other locations - About 55 mins to fix
      src/applications/simple-forms/mock-form-minimal-header/containers/IntroductionPage.jsx on lines 37..47
      src/applications/simple-forms/mock-form-minimal-header/containers/IntroductionPage.jsx on lines 97..107
      src/applications/simple-forms/mock-simple-forms-patterns-v3/containers/IntroductionPage.jsx on lines 175..185
      src/applications/static-pages/facilities/FacilityApiAlert.jsx on lines 6..19

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 53.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status