department-of-veterans-affairs/vets-website

View on GitHub
src/applications/mhv-medical-records/components/CareSummaries/AdmissionAndDischargeDetails.jsx

Summary

Maintainability
D
1 day
Test Coverage

Function AdmissionAndDischargeDetails has 135 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const AdmissionAndDischargeDetails = props => {
  const { record, runningUnitTest } = props;
  const user = useSelector(state => state.user.profile);
  const allowTxtDownloads = useSelector(
    state =>

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

      const generateCareNotesPDF = async () => {
        setDownloadStarted(true);
        const { title, subject, preface } = generateNotesIntro(record);
        const scaffold = generatePdfScaffold(user, title, subject, preface);
        const pdfData = { ...scaffold, ...generateDischargeSummaryContent(record) };
    src/applications/mhv-medical-records/components/CareSummaries/ProgressNoteDetails.jsx on lines 60..67
    src/applications/mhv-medical-records/components/LabsAndTests/ChemHemDetails.jsx on lines 65..72
    src/applications/mhv-medical-records/components/LabsAndTests/EkgDetails.jsx on lines 58..65
    src/applications/mhv-medical-records/components/LabsAndTests/MicroDetails.jsx on lines 63..70
    src/applications/mhv-medical-records/components/LabsAndTests/PathologyDetails.jsx on lines 61..68

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 108.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          <div className="test-results-container">
            <h2>Summary</h2>
            <p
              data-testid="note-summary"
              className="monospace vads-u-line-height--6"
    src/applications/mhv-medical-records/components/CareSummaries/ProgressNoteDetails.jsx on lines 138..146

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 61.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 5 locations. Consider refactoring.
    Open

      useEffect(
        () => {
          focusElement(document.querySelector('h1'));
          updatePageTitle(
            `${record.name} - ${pageTitles.CARE_SUMMARIES_AND_NOTES_PAGE_TITLE}`,
    src/applications/mhv-medical-records/components/CareSummaries/ProgressNoteDetails.jsx on lines 43..51
    src/applications/mhv-medical-records/components/LabsAndTests/MicroDetails.jsx on lines 46..54
    src/applications/mhv-medical-records/components/LabsAndTests/PathologyDetails.jsx on lines 44..52
    src/applications/mhv-medical-records/components/LabsAndTests/RadiologyDetails.jsx on lines 39..47

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 58.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

            {record.sortByField !== dischargeSummarySortFields.ADMISSION_DATE &&
              record.sortByField !== null && (
                <>
                  <h3 className="vads-u-font-size--base vads-u-font-family--sans">
                    Date admitted
    src/applications/mhv-medical-records/components/CareSummaries/AdmissionAndDischargeDetails.jsx on lines 155..162
    src/applications/mhv-medical-records/components/LabsAndTests/MicroDetails.jsx on lines 127..134

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 50.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

            {record.sortByField !== dischargeSummarySortFields.DISCHARGE_DATE && (
              <>
                <h3 className="vads-u-font-size--base vads-u-font-family--sans">
                  Date discharged
                </h3>
    src/applications/mhv-medical-records/components/CareSummaries/AdmissionAndDischargeDetails.jsx on lines 146..154
    src/applications/mhv-medical-records/components/LabsAndTests/MicroDetails.jsx on lines 127..134

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 50.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status