department-of-veterans-affairs/vets-website

View on GitHub
src/applications/mhv-medications/components/shared/PrintDownload.jsx

Summary

Maintainability
D
3 days
Test Coverage

Function PrintDownload has 206 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const PrintDownload = props => {
  const { onDownload, isSuccess, list, onPrint, onText, isLoading } = props;
  const [isError, setIsError] = useState(false);

  const [menuOpen, setMenuOpen] = useState(false);
Severity: Major
Found in src/applications/mhv-medications/components/shared/PrintDownload.jsx - About 1 day to fix

    Function PrintDownload has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
    Open

    const PrintDownload = props => {
      const { onDownload, isSuccess, list, onPrint, onText, isLoading } = props;
      const [isError, setIsError] = useState(false);
    
      const [menuOpen, setMenuOpen] = useState(false);
    Severity: Minor
    Found in src/applications/mhv-medications/components/shared/PrintDownload.jsx - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

              <li>
                <button
                  data-dd-action-name={`${
                    dataDogActionNames.shared.DOWNLOAD_A_PDF_OF_THIS
                  }${list ? 'List' : 'Page'} Option - ${
    src/applications/mhv-medications/components/shared/PrintDownload.jsx on lines 159..172

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 125.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

              <li>
                <button
                  data-dd-action-name={`${dataDogActionNames.shared.PRINT_THIS}${
                    list ? 'Page Of The List' : 'Page'
                  } Option - ${list ? pageType.LIST : pageType.DETAILS}`}
    src/applications/mhv-medications/components/shared/PrintDownload.jsx on lines 190..205

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 125.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 33 locations. Consider refactoring.
    Open

    PrintDownload.propTypes = {
      isSuccess: PropTypes.bool,
      list: PropTypes.any,
      onDownload: PropTypes.any,
      onPrint: PropTypes.func,
    src/applications/_mock-form-ae-design-patterns/patterns/pattern1/TaskGreen/VeteranProfileInformation.jsx on lines 117..124
    src/applications/_mock-form-ae-design-patterns/patterns/pattern1/TaskYellow/VeteranProfileInformationTaskYellow.jsx on lines 117..124
    src/applications/_mock-form-ae-design-patterns/patterns/pattern1/ezr/VeteranProfileInformation.jsx on lines 117..124
    src/applications/_mock-form-ae-design-patterns/patterns/pattern2/TaskGray/form/components/VeteranProfileInformation.jsx on lines 127..134
    src/applications/appeals/shared/content/contestableIssues.jsx on lines 116..123
    src/applications/caregivers/components/FormFields/FacilityList.jsx on lines 92..99
    src/applications/claims-status/components/ClaimDetailLayout.jsx on lines 135..142
    src/applications/claims-status/containers/ClaimStatusPage.jsx on lines 140..147
    src/applications/claims-status/containers/OverviewPage.jsx on lines 147..154
    src/applications/combined-debt-portal/medical-copays/components/AccountSummary.jsx on lines 63..70
    src/applications/disability-benefits/all-claims/components/Autocomplete.jsx on lines 173..180
    src/applications/ezr/components/FormPages/VeteranProfileInformation.jsx on lines 110..117
    src/applications/facility-locator/components/SearchResultMessage.jsx on lines 36..43
    src/applications/financial-status-report/components/veteranInformation/VeteranInfoBox.jsx on lines 53..60
    src/applications/gi/components/profile/EstimateYourBenefitsSummarySheet.jsx on lines 144..151
    src/applications/gi/containers/ProfilePageHeader.jsx on lines 401..408
    src/applications/hca/components/FormFields/VaMedicalCenter.jsx on lines 229..236
    src/applications/mhv-medications/components/MedicationsList/MedicationsList.jsx on lines 107..114
    src/applications/mhv-secure-messaging/components/ComposeForm/CategoryInput.jsx on lines 66..73
    src/applications/mhv-secure-messaging/components/ComposeForm/ElectronicSignature.jsx on lines 49..56
    src/applications/mhv-secure-messaging/components/MessageActionButtons/MoveMessageToFolderBtn.jsx on lines 268..275
    src/applications/mhv-secure-messaging/components/MessageList/MessageList.jsx on lines 235..242
    src/applications/mhv-secure-messaging/components/MessageThreadHeader.jsx on lines 140..147
    src/applications/mhv-secure-messaging/components/Modals/DeleteDraftModal.jsx on lines 69..76
    src/applications/representative-appoint/components/ContactCard.jsx on lines 33..40
    src/applications/static-pages/facilities/vet-center/NearByVetCenters.jsx on lines 246..253
    src/applications/vaos/components/FacilityPhone.jsx on lines 49..56
    src/applications/vaos/covid-19-vaccine/components/ConfirmationPageV2.jsx on lines 159..166
    src/applications/verify-your-enrollment/components/MoreInfoCard.jsx on lines 47..54
    src/applications/verify-your-enrollment/components/PayeeInformationCard.jsx on lines 73..80
    src/platform/forms-system/src/js/components/ConfirmationView/components.jsx on lines 226..233
    src/platform/user/authentication/components/VerifyButton.jsx on lines 45..52

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 66.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      const closeMenu = e => {
        if (
          containerEl.current &&
          menuOpen &&
          !containerEl.current.contains(e.target)
    src/applications/mhv-medical-records/components/shared/PrintDownload.jsx on lines 21..25

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 57.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

                  <p>
                    If it still doesn’t work, call us at{' '}
                    <va-telephone contact="8773270022" /> (
                    <va-telephone tty contact="711" />
                    ).
    src/applications/combined-debt-portal/combined/containers/OverviewPage.jsx on lines 88..93
    src/applications/combined-debt-portal/combined/containers/OverviewPage.jsx on lines 95..100
    src/applications/static-pages/health-care-manage-benefits/view-test-and-lab-results-page/components/UnauthContent/index.js on lines 120..125

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status