department-of-veterans-affairs/vets-website

View on GitHub
src/applications/mhv-secure-messaging/containers/ThreadDetails.jsx

Summary

Maintainability
C
1 day
Test Coverage

Function ThreadDetails has 160 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const ThreadDetails = props => {
  const { threadId } = useParams();
  const { testing } = props;
  const dispatch = useDispatch();
  const location = useLocation();
Severity: Major
Found in src/applications/mhv-secure-messaging/containers/ThreadDetails.jsx - About 6 hrs to fix

    Function content has 76 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      const content = () => {
        if (!isLoaded) {
          return (
            <va-loading-indicator
              message="Loading your secure message..."
    Severity: Major
    Found in src/applications/mhv-secure-messaging/containers/ThreadDetails.jsx - About 3 hrs to fix

      Function ThreadDetails has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
      Open

      const ThreadDetails = props => {
        const { threadId } = useParams();
        const { testing } = props;
        const dispatch = useDispatch();
        const location = useLocation();
      Severity: Minor
      Found in src/applications/mhv-secure-messaging/containers/ThreadDetails.jsx - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this function.
      Open

          return null;
      Severity: Major
      Found in src/applications/mhv-secure-messaging/containers/ThreadDetails.jsx - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status