Sign upLogin

department-of-veterans-affairs/vets-website

View on GitHub
Star
src/applications/my-education-benefits/components/IntroductionProcessListV1.jsx

Summary

Maintainability
B
5 hrs
Test Coverage

Function IntroductionProcessListV1 has 67 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function IntroductionProcessListV1() {
  return (
    <div className="process schemaform-process">
      <ol>
        <li className="process-step list-one">
Severity: Major
Found in src/applications/my-education-benefits/components/IntroductionProcessListV1.jsx - About 2 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                <ul>
              <li>
                {' '}
                You served at least 90 days on active duty (either all at once
                or with breaks in service) on or after September 11, 2001,{' '}
    Severity: Major
    Found in src/applications/my-education-benefits/components/IntroductionProcessListV1.jsx and 1 other location - About 2 hrs to fix
    src/applications/my-education-benefits/components/IntroductionProcessListV2.jsx on lines 13..30

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 79.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

              <va-additional-info trigger="What happens after I apply?">
            <p>
              After you apply, you may get an automatic decision. If we approve
              your application, you’ll be able to download your Certificate of
              Eligibility (or award letter) right away. If we deny your
    Severity: Major
    Found in src/applications/my-education-benefits/components/IntroductionProcessListV1.jsx and 2 other locations - About 1 hr to fix
    src/applications/discharge-wizard/components/v2/Homepage.jsx on lines 137..155
    src/applications/discharge-wizard/components/v2/Homepage.jsx on lines 156..180

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 56.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status