Sign upLogin

department-of-veterans-affairs/vets-website

View on GitHub
Star
src/applications/my-education-benefits/components/IntroductionProcessListV2.jsx
93cbcde1

Summary

Maintainability
B
6 hrs
Test Coverage

Function IntroductionProcessListV2 has 60 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function IntroductionProcessListV2() {
  return (
    <va-process-list>
      <va-process-list-item header="Check your eligibility">
        <p>Make sure you meet our eligibility requirements before you apply.</p>
Severity: Major
Found in src/applications/my-education-benefits/components/IntroductionProcessListV2.jsx - About 2 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

              <ul className="vads-u-margin-bottom--0">
            <li>
              {' '}
              You served at least 90 days on active duty (either all at once or
              with breaks in service) on or after September 11, 2001,{' '}
    Severity: Major
    Found in src/applications/my-education-benefits/components/IntroductionProcessListV2.jsx and 1 other location - About 2 hrs to fix
    src/applications/my-education-benefits/components/IntroductionProcessListV1.jsx on lines 17..34

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 79.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

          <va-process-list-item header="Gather your information">
        <p>
          <strong>Here’s what you’ll need to apply</strong>:
        </p>
        <ul>
    Severity: Major
    Found in src/applications/my-education-benefits/components/IntroductionProcessListV2.jsx and 2 other locations - About 1 hr to fix
    src/applications/edu-benefits/5490/containers/PreSubmitInfo.jsx on lines 35..46
    src/applications/edu-benefits/5490/containers/PreSubmitInfo.jsx on lines 76..90

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 67.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status