Sign upLogin

department-of-veterans-affairs/vets-website

View on GitHub
Star
src/applications/pensions/components/SectionField.jsx

Summary

Maintainability
D
2 days
Test Coverage

File SectionField.jsx has 577 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import React from 'react';
import { formatSSN } from 'platform/utilities/ui';
import { getJobTitleOrType } from '../helpers';

export const convertDateFormat = date => {
Severity: Major
Found in src/applications/pensions/components/SectionField.jsx - About 1 day to fix

    Function AdditionalInformation has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

    export function AdditionalInformation({ title, id, formData }) {
  return (
    <>
      <h2
        id={id}
    Severity: Minor
    Found in src/applications/pensions/components/SectionField.jsx - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

                          <p className="vads-u-margin-top--0 vads-u-margin-bottom--1">
                        <strong>Suffix: </strong>
                        {name?.suffix ? name?.suffix : 'None'}
                      </p>
    Severity: Major
    Found in src/applications/pensions/components/SectionField.jsx and 3 other locations - About 40 mins to fix
    src/applications/pensions/components/SectionField.jsx on lines 104..107
    src/applications/pensions/components/SectionField.jsx on lines 108..111
    src/applications/pensions/components/SectionField.jsx on lines 112..115

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 48.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

                          <p className="vads-u-margin-top--0 vads-u-margin-bottom--1">
                        <strong>Last: </strong>
                        {name?.last ? name?.last : ''}
                      </p>
    Severity: Major
    Found in src/applications/pensions/components/SectionField.jsx and 3 other locations - About 40 mins to fix
    src/applications/pensions/components/SectionField.jsx on lines 104..107
    src/applications/pensions/components/SectionField.jsx on lines 108..111
    src/applications/pensions/components/SectionField.jsx on lines 116..119

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 48.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

                          <p className="vads-u-margin-top--0 vads-u-margin-bottom--1">
                        <strong>First: </strong>
                        {name?.first ? name?.first : ''}
                      </p>
    Severity: Major
    Found in src/applications/pensions/components/SectionField.jsx and 3 other locations - About 40 mins to fix
    src/applications/pensions/components/SectionField.jsx on lines 108..111
    src/applications/pensions/components/SectionField.jsx on lines 112..115
    src/applications/pensions/components/SectionField.jsx on lines 116..119

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 48.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

                          <p className="vads-u-margin-top--0 vads-u-margin-bottom--1">
                        <strong>Middle: </strong>
                        {name?.middle ? name?.middle : ''}
                      </p>
    Severity: Major
    Found in src/applications/pensions/components/SectionField.jsx and 3 other locations - About 40 mins to fix
    src/applications/pensions/components/SectionField.jsx on lines 104..107
    src/applications/pensions/components/SectionField.jsx on lines 112..115
    src/applications/pensions/components/SectionField.jsx on lines 116..119

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 48.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                      <p className="vads-u-margin-top--0">
                    {convertDateFormat(
                      item?.dateRange?.from ? item?.dateRange?.from : '',
                    )}
                  </p>
    Severity: Minor
    Found in src/applications/pensions/components/SectionField.jsx and 1 other location - About 35 mins to fix
    src/applications/pensions/components/SectionField.jsx on lines 251..255

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                      <p className="vads-u-margin-top--0">
                    {convertDateFormat(
                      item?.dateRange?.to ? item?.dateRange?.to : '',
                    )}
                  </p>
    Severity: Minor
    Found in src/applications/pensions/components/SectionField.jsx and 1 other location - About 35 mins to fix
    src/applications/pensions/components/SectionField.jsx on lines 243..247

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 47.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

              <li>
            A completed Examination for Housebound Status or Permanent Need for
            Regular Aid and Attendance (
            <va-link
              href="http://www.vba.va.gov/pubs/forms/VBA-21-2680-ARE.pdf"
    Severity: Minor
    Found in src/applications/pensions/components/SectionField.jsx and 1 other location - About 30 mins to fix
    src/applications/pensions/components/SectionField.jsx on lines 551..562

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

              <li>
            A completed Request for Nursing Home Information in Connection with
            Claim for Aid and Attendance (
            <va-link
              href="http://www.vba.va.gov/pubs/forms/VBA-21-0779-ARE.pdf"
    Severity: Minor
    Found in src/applications/pensions/components/SectionField.jsx and 1 other location - About 30 mins to fix
    src/applications/pensions/components/SectionField.jsx on lines 539..550

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 45.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status