department-of-veterans-affairs/vets-website

View on GitHub
src/applications/pensions/containers/ConfirmationPage.jsx

Summary

Maintainability
D
1 day
Test Coverage

Function ConfirmationPage has 251 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const ConfirmationPage = props => {
  const { useToggleValue, TOGGLE_NAMES } = useFeatureToggle();
  const showUpdatedConfirmation = useToggleValue(
    TOGGLE_NAMES.pensionConfirmationUpdate,
  );
Severity: Major
Found in src/applications/pensions/containers/ConfirmationPage.jsx - About 1 day to fix

    File ConfirmationPage.jsx has 296 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import React, { useEffect } from 'react';
    import PropTypes from 'prop-types';
    
    import { utcToZonedTime, format } from 'date-fns-tz';
    import { connect } from 'react-redux';
    Severity: Minor
    Found in src/applications/pensions/containers/ConfirmationPage.jsx - About 3 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            veteranFullName: PropTypes.shape({
              first: PropTypes.string,
              middle: PropTypes.string,
              last: PropTypes.string,
              suffix: PropTypes.string,
      Severity: Minor
      Found in src/applications/pensions/containers/ConfirmationPage.jsx and 1 other location - About 55 mins to fix
      src/applications/disability-benefits/all-claims/containers/ConfirmationPage.jsx on lines 53..58

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 54.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

                <va-alert uswds>
                  <h4 slot="headline" className="vads-u-font-size--h4">
                    If we approve your application for pension benefits, we’ll use the
                    account you provided for all your VA benefit payments
                  </h4>
      Severity: Major
      Found in src/applications/pensions/containers/ConfirmationPage.jsx and 2 other locations - About 50 mins to fix
      src/applications/enrollment-verification/components/EnrollmentVerificationAlert.jsx on lines 69..85
      src/applications/mhv-medications/components/RefillPrescriptions/RefillNotification.jsx on lines 44..63

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 51.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status