Sign upLogin

department-of-veterans-affairs/vets-website

View on GitHub
Star
src/applications/personalization/profile/components/Profile.jsx

Summary

Maintainability
C
1 day
Test Coverage

File Profile.jsx has 309 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import React, { Component } from 'react';
import PropTypes from 'prop-types';
import { connect } from 'react-redux';
import { BrowserRouter, Route, Switch, Redirect } from 'react-router-dom';
import { LastLocationProvider } from 'react-router-last-location';
Severity: Minor
Found in src/applications/personalization/profile/components/Profile.jsx - About 3 hrs to fix

    Function mapStateToProps has 64 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    const mapStateToProps = state => {
  const togglesLoaded = togglesAreLoaded(state);
  const profileToggles = selectProfileToggles(state);
  const signInServicesEligibleForDD = new Set([
    CSP_IDS.ID_ME,
    Severity: Major
    Found in src/applications/personalization/profile/components/Profile.jsx - About 2 hrs to fix

      Function componentDidUpdate has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        componentDidUpdate(prevProps) {
    const {
      fetchDirectDeposit,
      fetchFullName,
      fetchMilitaryInformation,
      Severity: Minor
      Found in src/applications/personalization/profile/components/Profile.jsx - About 1 hr to fix

        Function mapStateToProps has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

        const mapStateToProps = state => {
  const togglesLoaded = togglesAreLoaded(state);
  const profileToggles = selectProfileToggles(state);
  const signInServicesEligibleForDD = new Set([
    CSP_IDS.ID_ME,
        Severity: Minor
        Found in src/applications/personalization/profile/components/Profile.jsx - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Consider simplifying this complex logical expression.
        Open

            if (
      (togglesLoaded && !prevProps.togglesLoaded && shouldFetchDirectDeposit) ||
      (togglesLoaded &&
        shouldFetchDirectDeposit &&
        !prevProps.shouldFetchDirectDeposit)
        Severity: Major
        Found in src/applications/personalization/profile/components/Profile.jsx - About 40 mins to fix

          Consider simplifying this complex logical expression.
          Open

                          if (
                  (route.requiresLOA3 && !this.props.isLOA3) ||
                  (route.requiresMVI && !this.props.isInMVI) ||
                  (route.requiresLOA3 && this.props.isBlocked)
                ) {
          Severity: Major
          Found in src/applications/personalization/profile/components/Profile.jsx - About 40 mins to fix

            Similar blocks of code found in 7 locations. Consider refactoring.
            Open

                const {
      fetchDirectDeposit,
      fetchFullName,
      fetchMilitaryInformation,
      fetchPersonalInformation,
            Severity: Major
            Found in src/applications/personalization/profile/components/Profile.jsx and 6 other locations - About 1 hr to fix
            src/applications/disability-benefits/all-claims/components/ArrayField.jsx on lines 316..327
            src/applications/pre-need-integration/components/DeceasedPersons.jsx on lines 310..321
            src/platform/forms-system/src/js/fields/ArrayField.jsx on lines 318..329
            src/platform/forms-system/src/js/fields/BasicArrayField.jsx on lines 29..40
            src/platform/forms/save-in-progress/ApplicationStatus.jsx on lines 71..82
            src/platform/user/profile/vap-svc/containers/VAPServiceProfileField.jsx on lines 193..204

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 62.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status