department-of-veterans-affairs/vets-website

View on GitHub
src/applications/post-911-gib-status/utils/helpers.jsx

Summary

Maintainability
D
2 days
Test Coverage

File helpers.jsx has 264 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import React from 'react';
import { Link } from 'react-router';
import moment from 'moment';

import {
Severity: Minor
Found in src/applications/post-911-gib-status/utils/helpers.jsx - About 2 hrs to fix

    Function notQualifiedWarning has 48 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export function notQualifiedWarning() {
      return (
        <div className="usa-alert usa-alert-warning usa-content not-qualified">
          <div className="usa-alert-body">
            <h2>You don't qualify</h2>
    Severity: Minor
    Found in src/applications/post-911-gib-status/utils/helpers.jsx - About 1 hr to fix

      Function benefitEndDateExplanation has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export function benefitEndDateExplanation(condition, delimitingDate) {
        switch (condition) {
          case 'activeDuty':
            return (
              <div className="section benefit-end-date">
      Severity: Minor
      Found in src/applications/post-911-gib-status/utils/helpers.jsx - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        export const serviceDowntimeErrorMessage = (
          <div
            id="serviceDowntimeErrorMessage"
            className="vads-u-margin-bottom--2 grid-col usa-width-two-thirds"
          >
        Severity: Major
        Found in src/applications/post-911-gib-status/utils/helpers.jsx and 1 other location - About 4 hrs to fix
        src/applications/post-911-gib-status/utils/helpers.jsx on lines 166..188

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 117.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        export const backendErrorMessage = (
          <div
            id="backendErrorMessage"
            className="vads-u-margin-bottom--2 grid-col usa-width-two-thirds"
          >
        Severity: Major
        Found in src/applications/post-911-gib-status/utils/helpers.jsx and 1 other location - About 4 hrs to fix
        src/applications/post-911-gib-status/utils/helpers.jsx on lines 190..213

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 117.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              <ul>
                <li>
                  Your school made a request to us that’s still in process,{' '}
                  <strong>or</strong>
                </li>
        Severity: Major
        Found in src/applications/post-911-gib-status/utils/helpers.jsx and 1 other location - About 2 hrs to fix
        src/applications/hca/components/FormDescriptions/index.jsx on lines 167..178

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 81.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 8 locations. Consider refactoring.
        Open

              <ul>
                <li>
                  You or your school did not yet make a request to us,{' '}
                  <strong>or</strong>
                </li>
        Severity: Major
        Found in src/applications/post-911-gib-status/utils/helpers.jsx and 7 other locations - About 1 hr to fix
        src/applications/claims-status/components/StemDeniedDetails.jsx on lines 96..105
        src/applications/coronavirus-screener/config/questions.jsx on lines 185..191
        src/applications/enrollment-verification/containers/EnrollmentVerificationIntroPage.jsx on lines 127..133
        src/applications/mhv-medications/components/shared/StatusDropdown.jsx on lines 139..145
        src/applications/pensions/config/chapters/06-additional-information/supportingDocuments.js on lines 185..196
        src/applications/simple-forms/20-10207/containers/IntroductionPage.jsx on lines 125..131
        src/applications/simple-forms/21-0966/containers/IntroductionPage.jsx on lines 37..48

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 55.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status