department-of-veterans-affairs/vets-website

View on GitHub
src/applications/representative-appoint/containers/IntroductionPage.jsx

Summary

Maintainability
C
1 day
Test Coverage

Function IntroductionPage has 134 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const IntroductionPage = props => {
  const { route, loggedIn } = props;
  const { formConfig, pageList } = route;
  const store = useStore();

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

              <va-process-list-item header="Gather your information" level="3">
                <p>Here’s what you’ll need to complete this form:</p>
                <ul>
                  <li>Your Social Security number or VA file number</li>
                  <li>Your date of birth</li>
    src/applications/pact-act/constants/results-set-1-page-2-dynamic-content.jsx on lines 201..218

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 106.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

              <va-process-list-item header="Start your form" level="3">
                <p>
                  We’ll take you through each step of our online tool. It should
                  take about 5 minutes.
                </p>
    src/applications/static-pages/health-care-manage-benefits/get-medical-records-page/components/AuthContent/index.js on lines 177..190
    src/applications/static-pages/health-care-manage-benefits/get-medical-records-page/components/UnauthContent/index.js on lines 146..158

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 48.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status