Sign upLogin

department-of-veterans-affairs/vets-website

View on GitHub
Star
src/applications/representative-search/components/search/SearchControls.jsx

Summary

Maintainability
F
3 days
Test Coverage

Function SearchControls has 252 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const SearchControls = props => {
  const {
    currentQuery,
    onChange,
    geolocateUser,
Severity: Major
Found in src/applications/representative-search/components/search/SearchControls.jsx - About 1 day to fix

    File SearchControls.jsx has 277 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import React from 'react';
import PropTypes from 'prop-types';
import classNames from 'classnames';
import {
  VaModal,
    Severity: Minor
    Found in src/applications/representative-search/components/search/SearchControls.jsx - About 2 hrs to fix

      Function SearchControls has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

      const SearchControls = props => {
  const {
    currentQuery,
    onChange,
    geolocateUser,
      Severity: Minor
      Found in src/applications/representative-search/components/search/SearchControls.jsx - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 13 locations. Consider refactoring.
      Open

      SearchControls.propTypes = {
  clearError: PropTypes.func,
  currentQuery: PropTypes.object,
  geocodeError: PropTypes.object,
  geolocateUser: PropTypes.func,
      Severity: Major
      Found in src/applications/representative-search/components/search/SearchControls.jsx and 12 other locations - About 2 hrs to fix
      src/applications/_mock-form-ae-design-patterns/patterns/pattern1/ezr/components/DependentSummary.jsx on lines 147..157
      src/applications/_mock-form-ae-design-patterns/patterns/pattern1/ezr/components/InsuranceSummary.jsx on lines 159..169
      src/applications/check-in/components/pages/validate/ValidateDisplay.jsx on lines 166..176
      src/applications/ezr/components/FormPages/DependentSummary.jsx on lines 144..154
      src/applications/ezr/components/FormPages/InsuranceSummary.jsx on lines 155..165
      src/applications/facility-locator/components/ResultsList.jsx on lines 269..279
      src/applications/hca/components/FormPages/DependentSummary.jsx on lines 142..152
      src/applications/mhv-secure-messaging/components/MessageActionButtons.jsx on lines 96..106
      src/applications/personalization/view-dependents/components/ViewDependentsList/ViewDependentsListItem.jsx on lines 127..137
      src/applications/vaos/new-appointment/components/CommunityCareProviderSelectionPage/ProviderList.jsx on lines 234..244
      src/applications/verify-your-enrollment/containers/VerificationReviewWrapper.jsx on lines 241..251
      src/applications/check-in/components/ExternalLink.jsx on lines 50..60

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 93.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                <div className="vads-u-margin-top--2p5">
            <va-additional-info
              trigger="What does an accredited attorney do?"
              disable-border
              uswds
      Severity: Major
      Found in src/applications/representative-search/components/search/SearchControls.jsx and 1 other location - About 2 hrs to fix
      src/applications/representative-search/components/search/SearchControls.jsx on lines 155..172

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 88.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                <div className="vads-u-margin-top--2p5">
            <va-additional-info
              trigger="What does an accredited claims agent do?"
              disable-border
              uswds
      Severity: Major
      Found in src/applications/representative-search/components/search/SearchControls.jsx and 1 other location - About 2 hrs to fix
      src/applications/representative-search/components/search/SearchControls.jsx on lines 135..153

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 88.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        const handleRepresentativeChange = e => {
    onChange({
      representativeInputString: onlySpaces(e.target.value)
        ? e.target.value.trim()
        : e.target.value,
      Severity: Major
      Found in src/applications/representative-search/components/search/SearchControls.jsx and 1 other location - About 1 hr to fix
      src/applications/representative-search/components/search/SearchControls.jsx on lines 55..61

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 67.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        const handleSearchAreaChange = e => {
    onChange({
      searchArea: onlySpaces(e.target.value)
        ? e.target.value.trim()
        : e.target.value,
      Severity: Major
      Found in src/applications/representative-search/components/search/SearchControls.jsx and 1 other location - About 1 hr to fix
      src/applications/representative-search/components/search/SearchControls.jsx on lines 62..68

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 67.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        const searchAreaSelectOptions = Object.keys(searchAreaOptions).map(
    optionKey => (
      <option key={optionKey} value={optionKey}>
        {searchAreaOptions[optionKey]}
      </option>
      Severity: Major
      Found in src/applications/representative-search/components/search/SearchControls.jsx and 1 other location - About 1 hr to fix
      src/applications/facility-locator/components/SearchControls.jsx on lines 230..234

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 60.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status