Sign upLogin

department-of-veterans-affairs/vets-website

View on GitHub
Star
src/applications/search/components/SearchMaintenance.jsx

Summary

Maintainability
A
30 mins
Test Coverage

Similar blocks of code found in 16 locations. Consider refactoring.
Open

      <div className="vads-u-margin-bottom--1p5">
        <va-banner
          data-label="Error banner"
          headline="Search Maintenance"
          type="warning"
Severity: Major
Found in src/applications/search/components/SearchMaintenance.jsx and 15 other locations - About 30 mins to fix
src/applications/appeals/testing/nod-new/components/ContactInformation.jsx on lines 40..48
src/applications/appeals/testing/nod-new/components/ContactInformation.jsx on lines 58..66
src/applications/appeals/testing/nod-new/components/ContactInformation.jsx on lines 73..81
src/applications/appeals/testing/nod-new/components/ContactInformation.jsx on lines 94..102
src/applications/caregivers/components/IntroductionPage/ProcessTimeline.jsx on lines 50..58
src/applications/disability-benefits/all-claims/content/toxicExposure.jsx on lines 28..36
src/applications/ds-playground/pages/V1V3Page.jsx on lines 719..727
src/applications/financial-status-report/components/contactInfo/ContactInfo.jsx on lines 138..146
src/applications/financial-status-report/components/contactInfo/ContactInfo.jsx on lines 151..159
src/applications/financial-status-report/components/contactInfo/ContactInfo.jsx on lines 166..174
src/applications/pensions/components/FormAlerts/index.jsx on lines 234..246
src/applications/simple-forms/21-4138/config/constants.js on lines 182..190
src/applications/simple-forms/21-4138/config/constants.js on lines 209..217
src/applications/simple-forms/21-4138/config/constants.js on lines 254..263
src/applications/simple-forms/21-4138/config/constants.js on lines 296..304

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status