department-of-veterans-affairs/vets-website

View on GitHub
src/applications/simple-forms/20-10207/containers/IntroductionPage.jsx

Summary

Maintainability
D
2 days
Test Coverage

Function IntroductionPage has 259 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const IntroductionPage = props => {
  const { route } = props;
  // WIP: need to keep unit-tests passing with these new selector-hooks
  const userLoggedIn = useSelector(state => isLoggedIn(state));
  const userIdVerified = useSelector(state => isLOA3(state));

    File IntroductionPage.jsx has 280 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import React, { useEffect } from 'react';
    
    import PropTypes from 'prop-types';
    import { useDispatch, useSelector } from 'react-redux';
    import { setData } from '~/platform/forms-system/src/js/actions';

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

            <p>
              <strong>Note</strong>: You’ll need to sign in with a verified{' '}
              <strong>Login.gov</strong> or <strong>ID.me</strong> account or a
              Premium <strong>DS Logon</strong> or <strong>My HealtheVet</strong>{' '}
              account. If you don’t have any of those accounts, you can create a free{' '}
      src/applications/simple-forms/20-10206/containers/IntroductionPage.jsx on lines 107..113
      src/applications/simple-forms/21-4142/containers/IntroductionPage.jsx on lines 55..62

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 114.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 5 locations. Consider refactoring.
      Open

      IntroductionPage.propTypes = {
        route: PropTypes.shape({
          formConfig: PropTypes.shape({
            prefillEnabled: PropTypes.bool.isRequired,
            savedFormMessages: PropTypes.object.isRequired,
      src/applications/simple-forms/21-10210/containers/IntroductionPage.jsx on lines 72..80
      src/applications/simple-forms/21-4138/containers/IntroductionPage.jsx on lines 76..84
      src/applications/simple-forms/40-0247/containers/IntroductionPage.jsx on lines 110..118
      src/applications/simple-forms/form-upload/containers/IntroductionPage.jsx on lines 104..112

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 95.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 8 locations. Consider refactoring.
      Open

            <ul>
              <li>
                Military personnel records, such as a determination from the DOD{' '}
                <strong>and</strong>
              </li>
      src/applications/claims-status/components/StemDeniedDetails.jsx on lines 96..105
      src/applications/coronavirus-screener/config/questions.jsx on lines 185..191
      src/applications/enrollment-verification/containers/EnrollmentVerificationIntroPage.jsx on lines 127..133
      src/applications/mhv-medications/components/shared/StatusDropdown.jsx on lines 139..145
      src/applications/pensions/config/chapters/06-additional-information/supportingDocuments.js on lines 185..196
      src/applications/post-911-gib-status/utils/helpers.jsx on lines 72..78
      src/applications/simple-forms/21-0966/containers/IntroductionPage.jsx on lines 37..48

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 55.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status