department-of-veterans-affairs/vets-website

View on GitHub
src/applications/simple-forms/21-0966/components/DevOnlyTestVariations.jsx

Summary

Maintainability
A
3 hrs
Test Coverage

Similar blocks of code found in 36 locations. Consider refactoring.
Open

DevOnlyTestVariations.propTypes = {
  formData: PropTypes.object,
  setFormData: PropTypes.func,
  setSubmissionResponse: PropTypes.func,
  setSubmitDate: PropTypes.func,
src/applications/_mock-form-ae-design-patterns/patterns/pattern1/TaskGreen/VeteranProfileInformation.jsx on lines 117..124
src/applications/_mock-form-ae-design-patterns/patterns/pattern1/TaskYellow/VeteranProfileInformationTaskYellow.jsx on lines 117..124
src/applications/_mock-form-ae-design-patterns/patterns/pattern1/ezr/VeteranProfileInformation.jsx on lines 117..124
src/applications/_mock-form-ae-design-patterns/patterns/pattern2/TaskGray/form/components/VeteranProfileInformation.jsx on lines 134..141
src/applications/appeals/shared/content/contestableIssues.jsx on lines 116..123
src/applications/ask-va/components/YourPersonalInformationAuthenticated.jsx on lines 85..92
src/applications/caregivers/components/FormFields/FacilityList.jsx on lines 94..101
src/applications/claims-status/components/ClaimDetailLayout.jsx on lines 135..142
src/applications/claims-status/containers/ClaimStatusPage.jsx on lines 140..147
src/applications/claims-status/containers/OverviewPage.jsx on lines 147..154
src/applications/combined-debt-portal/medical-copays/components/AccountSummary.jsx on lines 63..70
src/applications/disability-benefits/all-claims/components/Autocomplete.jsx on lines 220..227
src/applications/ezr/components/FormPages/VeteranProfileInformation.jsx on lines 110..117
src/applications/facility-locator/components/SearchResultMessage.jsx on lines 36..43
src/applications/financial-status-report/components/veteranInformation/VeteranInfoBox.jsx on lines 53..60
src/applications/gi/components/profile/EstimateYourBenefitsSummarySheet.jsx on lines 144..151
src/applications/gi/containers/ProfilePageHeader.jsx on lines 401..408
src/applications/hca/components/FormFields/VaMedicalCenter.jsx on lines 231..238
src/applications/mhv-medications/components/shared/PrintDownload.jsx on lines 230..237
src/applications/mhv-secure-messaging/components/ComposeForm/CategoryInput.jsx on lines 66..73
src/applications/mhv-secure-messaging/components/ComposeForm/ElectronicSignature.jsx on lines 49..56
src/applications/mhv-secure-messaging/components/MessageActionButtons/MoveMessageToFolderBtn.jsx on lines 268..275
src/applications/mhv-secure-messaging/components/MessageList/MessageList.jsx on lines 235..242
src/applications/mhv-secure-messaging/components/MessageThreadHeader.jsx on lines 140..147
src/applications/mhv-secure-messaging/components/Modals/DeleteDraftModal.jsx on lines 69..76
src/applications/representative-appoint/components/ContactCard.jsx on lines 33..40
src/applications/representative-appoint/components/ProfileNotUpdatedNote.jsx on lines 58..65
src/applications/static-pages/facilities/vet-center/NearByVetCenters.jsx on lines 248..255
src/applications/user-testing/new-conditions/components/Autocomplete.jsx on lines 220..227
src/applications/vaos/components/FacilityPhone.jsx on lines 57..64
src/applications/vaos/covid-19-vaccine/components/ConfirmationPageV2.jsx on lines 159..166
src/applications/verify-your-enrollment/components/MoreInfoCard.jsx on lines 47..54
src/applications/verify-your-enrollment/components/PayeeInformationCard.jsx on lines 76..83
src/platform/forms-system/src/js/components/ConfirmationView/components.jsx on lines 226..233
src/platform/forms-system/src/js/components/EditContactInfo.jsx on lines 101..108

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 66.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

            <va-checkbox
              label="Compensation"
              data-key={veteranBenefits.COMPENSATION}
              checked={
                !!newFormData.benefitSelection?.[veteranBenefits.COMPENSATION]
src/applications/simple-forms/21-0966/components/DevOnlyTestVariations.jsx on lines 172..178
src/applications/simple-forms/21-0966/components/DevOnlyTestVariations.jsx on lines 179..187

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

            <va-checkbox
              label="Pension"
              data-key={veteranBenefits.PENSION}
              checked={
                !!newFormData.benefitSelection?.[veteranBenefits.PENSION]
src/applications/simple-forms/21-0966/components/DevOnlyTestVariations.jsx on lines 165..171
src/applications/simple-forms/21-0966/components/DevOnlyTestVariations.jsx on lines 179..187

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

            <va-checkbox
              label="Survivor"
              data-key={survivingDependentBenefits.SURVIVOR}
              checked={
                !!newFormData.benefitSelection?.[
src/applications/simple-forms/21-0966/components/DevOnlyTestVariations.jsx on lines 165..171
src/applications/simple-forms/21-0966/components/DevOnlyTestVariations.jsx on lines 172..178

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status