Sign upLogin

department-of-veterans-affairs/vets-website

View on GitHub
Star
src/applications/static-pages/facilities/OtherFacilityListWidget.jsx

Summary

Maintainability
B
4 hrs
Test Coverage

Function render has 55 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  render() {
    if (this.state.loading) {
      return <va-loading-indicator message="Loading facilities..." />;
    }
Severity: Major
Found in src/applications/static-pages/facilities/OtherFacilityListWidget.jsx - About 2 hrs to fix

    Function facilitiesList has 44 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          facility => {
        const processed = processPhoneNumber(facility.attributes.phone.main);
        const phone = processed.processed ? (
          <va-telephone
            contact={processed.phone}
    Severity: Minor
    Found in src/applications/static-pages/facilities/OtherFacilityListWidget.jsx - About 1 hr to fix

      Function render has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        render() {
    if (this.state.loading) {
      return <va-loading-indicator message="Loading facilities..." />;
    }
      Severity: Minor
      Found in src/applications/static-pages/facilities/OtherFacilityListWidget.jsx - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status