Sign upLogin

department-of-veterans-affairs/vets-website

View on GitHub
Star
src/applications/terms-of-use/touData.jsx

Summary

Maintainability
C
1 day
Test Coverage

File touData.jsx has 405 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import React from 'react';
import { CONTACTS } from '@department-of-veterans-affairs/component-library/contacts';

export default [
  {
Severity: Minor
Found in src/applications/terms-of-use/touData.jsx - About 5 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

              <li>
            Federal law and VA policy prohibit unauthorized use of this system.
            Unauthorized use may result in criminal, civil, or administrative
            penalties. The related federal laws include{' '}
            <a
    Severity: Major
    Found in src/applications/terms-of-use/touData.jsx and 1 other location - About 2 hrs to fix
    src/applications/auth/components/RenderErrorContainer.jsx on lines 120..137

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 79.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

            <p>
          If you disagree with the content included in your VA records, or you
          suspect an error in your record, call our MyVA411 main information
          line at <va-telephone contact={CONTACTS.VA_411} /> (
          <va-telephone contact={CONTACTS[711]} tty />
    Severity: Major
    Found in src/applications/terms-of-use/touData.jsx and 5 other locations - About 55 mins to fix
    src/applications/appeals/10182/components/ConfirmationPageV2.jsx on lines 178..182
    src/applications/appeals/996/containers/ConfirmationPage.jsx on lines 56..60
    src/applications/appeals/testing/download/containers/Confirmation.jsx on lines 225..229
    src/applications/personalization/profile/components/proof-of-veteran-status/ProofOfVeteranStatus.jsx on lines 200..206
    src/applications/terms-of-use/touData.jsx on lines 97..104

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 53.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

            <p>
          If you don’t accept these terms, you won’t be able to sign in to
          VA.gov or other VA online services covered by these terms. If you have
          concerns or questions, or want to report an issue, call our MyVA411
          main information line at <va-telephone contact={CONTACTS.VA_411} /> (
    Severity: Major
    Found in src/applications/terms-of-use/touData.jsx and 5 other locations - About 55 mins to fix
    src/applications/appeals/10182/components/ConfirmationPageV2.jsx on lines 178..182
    src/applications/appeals/996/containers/ConfirmationPage.jsx on lines 56..60
    src/applications/appeals/testing/download/containers/Confirmation.jsx on lines 225..229
    src/applications/personalization/profile/components/proof-of-veteran-status/ProofOfVeteranStatus.jsx on lines 200..206
    src/applications/terms-of-use/touData.jsx on lines 150..156

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 53.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

      {
    header: `Changes to these terms of use`,
    content: (
      <>
        <p>
    Severity: Major
    Found in src/applications/terms-of-use/touData.jsx and 3 other locations - About 40 mins to fix
    src/applications/terms-of-use/touData.jsx on lines 114..131
    src/applications/terms-of-use/touData.jsx on lines 333..354
    src/applications/terms-of-use/touData.jsx on lines 355..373

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 49.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

      {
    header: `Use of VA online services`,
    content: (
      <>
        <p>
    Severity: Major
    Found in src/applications/terms-of-use/touData.jsx and 3 other locations - About 40 mins to fix
    src/applications/terms-of-use/touData.jsx on lines 333..354
    src/applications/terms-of-use/touData.jsx on lines 355..373
    src/applications/terms-of-use/touData.jsx on lines 374..392

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 49.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

      {
    header: `Use of contact information`,
    content: (
      <>
        <p>
    Severity: Major
    Found in src/applications/terms-of-use/touData.jsx and 3 other locations - About 40 mins to fix
    src/applications/terms-of-use/touData.jsx on lines 114..131
    src/applications/terms-of-use/touData.jsx on lines 355..373
    src/applications/terms-of-use/touData.jsx on lines 374..392

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 49.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

      {
    header: `Feedback`,
    content: (
      <>
        <p>
    Severity: Major
    Found in src/applications/terms-of-use/touData.jsx and 3 other locations - About 40 mins to fix
    src/applications/terms-of-use/touData.jsx on lines 114..131
    src/applications/terms-of-use/touData.jsx on lines 333..354
    src/applications/terms-of-use/touData.jsx on lines 374..392

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 49.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status