Sign upLogin

department-of-veterans-affairs/vets-website

View on GitHub
Star
src/applications/toe/components/CustomPhoneNumberField.jsx

Summary

Maintainability
D
1 day
Test Coverage

Function CustomPhoneNumberField has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function CustomPhoneNumberField(props) {
  function handleChange(event) {
    if (props?.toeDupContactInfoCall) {
      props?.updateGlobalPhoneNumber(event);
      if (event?.length > 9) {
Severity: Minor
Found in src/applications/toe/components/CustomPhoneNumberField.jsx - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    function CustomPhoneNumberField(props) {
  function handleChange(event) {
    if (props?.toeDupContactInfoCall) {
      props?.updateGlobalPhoneNumber(event);
      if (event?.length > 9) {
    Severity: Major
    Found in src/applications/toe/components/CustomPhoneNumberField.jsx and 1 other location - About 1 day to fix
    src/applications/my-education-benefits/components/CustomPhoneNumberField.jsx on lines 9..42

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 202.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    const mapStateToProps = state => ({
  mobilePhone: state?.form?.data['view:phoneNumbers']?.mobilePhoneNumber?.phone,
  duplicatePhone: state?.data?.duplicatePhone,
  email: state?.form?.data?.email?.email,
  duplicateEmail: state?.data?.duplicateEmail,
    Severity: Major
    Found in src/applications/toe/components/CustomPhoneNumberField.jsx and 1 other location - About 3 hrs to fix
    src/applications/my-education-benefits/components/CustomPhoneNumberField.jsx on lines 50..57

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 110.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status