Sign upLogin

department-of-veterans-affairs/vets-website

View on GitHub
Star
src/applications/vaos/appointment-list/components/cancel/CancelPageLayout.jsx

Summary

Maintainability
F
3 days
Test Coverage

Function CancelPageLayout has 136 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export default function CancelPageLayout() {
  const { id } = useParams();
  const {
    appointment,
    clinicName,
Severity: Major
Found in src/applications/vaos/appointment-list/components/cancel/CancelPageLayout.jsx - About 5 hrs to fix

    Avoid too many return statements within this function.
    Open

      return 'Not defined';
    Severity: Major
    Found in src/applications/vaos/appointment-list/components/cancel/CancelPageLayout.jsx - About 30 mins to fix

      Function getHeading has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

      function getHeading(appointment) {
  const isCanceled = selectIsCanceled(appointment);

  if (selectIsInPerson(appointment)) {
    if (isCanceled) return 'Canceled in-person appointment';
      Severity: Minor
      Found in src/applications/vaos/appointment-list/components/cancel/CancelPageLayout.jsx - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

              <Where level={3}>
          {/* When the services return a null value for the facility (no facility ID) for all appointment types */}
          {!facility &&
            !facilityId && (
              <>
      Severity: Major
      Found in src/applications/vaos/appointment-list/components/cancel/CancelPageLayout.jsx and 2 other locations - About 2 days to fix
      src/applications/vaos/components/layout/ClaimExamLayout.jsx on lines 73..129
      src/applications/vaos/components/layout/InPersonLayout.jsx on lines 74..128

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 367.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

        const {
    appointment,
    clinicName,
    clinicPhone,
    clinicPhoneExtension,
      Severity: Major
      Found in src/applications/vaos/appointment-list/components/cancel/CancelPageLayout.jsx and 4 other locations - About 2 hrs to fix
      src/applications/vaos/components/layout/ClaimExamLayout.jsx on lines 28..44
      src/applications/vaos/components/layout/InPersonLayout.jsx on lines 27..43
      src/applications/vaos/components/layout/VideoLayoutAtlas.jsx on lines 28..44
      src/applications/vaos/components/layout/VideoLayoutVA.jsx on lines 26..42

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 82.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                {!!facility && (
            <>
              {facility.name}
              <br />
              <Address address={facility?.address} />
      Severity: Minor
      Found in src/applications/vaos/appointment-list/components/cancel/CancelPageLayout.jsx and 1 other location - About 50 mins to fix
      src/applications/vaos/components/layout/PhoneLayout.jsx on lines 86..92

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 52.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status