department-of-veterans-affairs/vets-website

View on GitHub
src/applications/vaos/covid-19-vaccine/index.jsx

Summary

Maintainability
D
2 days
Test Coverage

Function NewBookingSection has 141 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function NewBookingSection() {
  const match = useRouteMatch();
  const location = useLocation();
  const dispatch = useDispatch();
  const canUseVaccineFlow = useSelector(selectCanUseVaccineFlow);
Severity: Major
Found in src/applications/vaos/covid-19-vaccine/index.jsx - About 5 hrs to fix

    Function NewBookingSection has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

    export function NewBookingSection() {
      const match = useRouteMatch();
      const location = useLocation();
      const dispatch = useDispatch();
      const canUseVaccineFlow = useSelector(selectCanUseVaccineFlow);
    Severity: Minor
    Found in src/applications/vaos/covid-19-vaccine/index.jsx - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

      return (
        <FormLayout pageTitle={crumb}>
          <Switch>
            <Route
              path={
    Severity: Major
    Found in src/applications/vaos/covid-19-vaccine/index.jsx - About 30 mins to fix

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

              <Route
                path={
                  featureBreadcrumbUrlUpdate
                    ? `${match.url}/clinic`
                    : `${match.url}/choose-clinic`
      Severity: Major
      Found in src/applications/vaos/covid-19-vaccine/index.jsx and 5 other locations - About 1 hr to fix
      src/applications/vaos/covid-19-vaccine/index.jsx on lines 115..125
      src/applications/vaos/covid-19-vaccine/index.jsx on lines 129..137
      src/applications/vaos/covid-19-vaccine/index.jsx on lines 147..155
      src/applications/vaos/covid-19-vaccine/index.jsx on lines 156..164
      src/applications/vaos/covid-19-vaccine/index.jsx on lines 165..173

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 74.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

              <Route
                path={
                  featureBreadcrumbUrlUpdate
                    ? `${match.url}/date-time`
                    : `${match.url}/select-date`
      Severity: Major
      Found in src/applications/vaos/covid-19-vaccine/index.jsx and 5 other locations - About 1 hr to fix
      src/applications/vaos/covid-19-vaccine/index.jsx on lines 115..125
      src/applications/vaos/covid-19-vaccine/index.jsx on lines 129..137
      src/applications/vaos/covid-19-vaccine/index.jsx on lines 138..146
      src/applications/vaos/covid-19-vaccine/index.jsx on lines 156..164
      src/applications/vaos/covid-19-vaccine/index.jsx on lines 165..173

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 74.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

              <Route
                path={
                  featureBreadcrumbUrlUpdate
                    ? `${match.url}/second-dose`
                    : `${match.url}/second-dose-info`
      Severity: Major
      Found in src/applications/vaos/covid-19-vaccine/index.jsx and 5 other locations - About 1 hr to fix
      src/applications/vaos/covid-19-vaccine/index.jsx on lines 115..125
      src/applications/vaos/covid-19-vaccine/index.jsx on lines 129..137
      src/applications/vaos/covid-19-vaccine/index.jsx on lines 138..146
      src/applications/vaos/covid-19-vaccine/index.jsx on lines 147..155
      src/applications/vaos/covid-19-vaccine/index.jsx on lines 165..173

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 74.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

              <Route
                path={
                  featureBreadcrumbUrlUpdate
                    ? `${match.url}/location`
                    : `${match.url}/choose-facility`
      Severity: Major
      Found in src/applications/vaos/covid-19-vaccine/index.jsx and 5 other locations - About 1 hr to fix
      src/applications/vaos/covid-19-vaccine/index.jsx on lines 115..125
      src/applications/vaos/covid-19-vaccine/index.jsx on lines 138..146
      src/applications/vaos/covid-19-vaccine/index.jsx on lines 147..155
      src/applications/vaos/covid-19-vaccine/index.jsx on lines 156..164
      src/applications/vaos/covid-19-vaccine/index.jsx on lines 165..173

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 74.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

              <Route
                path={
                  featureBreadcrumbUrlUpdate
                    ? `${match.url}/doses-received`
                    : `${match.url}/confirm-doses-received`
      Severity: Major
      Found in src/applications/vaos/covid-19-vaccine/index.jsx and 5 other locations - About 1 hr to fix
      src/applications/vaos/covid-19-vaccine/index.jsx on lines 129..137
      src/applications/vaos/covid-19-vaccine/index.jsx on lines 138..146
      src/applications/vaos/covid-19-vaccine/index.jsx on lines 147..155
      src/applications/vaos/covid-19-vaccine/index.jsx on lines 156..164
      src/applications/vaos/covid-19-vaccine/index.jsx on lines 165..173

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 74.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 6 locations. Consider refactoring.
      Open

              <Route
                path={
                  featureBreadcrumbUrlUpdate
                    ? `${match.url}/contact-information`
                    : `${match.url}/contact-info`
      Severity: Major
      Found in src/applications/vaos/covid-19-vaccine/index.jsx and 5 other locations - About 1 hr to fix
      src/applications/vaos/covid-19-vaccine/index.jsx on lines 115..125
      src/applications/vaos/covid-19-vaccine/index.jsx on lines 129..137
      src/applications/vaos/covid-19-vaccine/index.jsx on lines 138..146
      src/applications/vaos/covid-19-vaccine/index.jsx on lines 147..155
      src/applications/vaos/covid-19-vaccine/index.jsx on lines 156..164

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 74.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 11 locations. Consider refactoring.
      Open

              <Route path={`${match.url}/review`}>
                <ReviewPage changeCrumb={newTitle => setCrumb(newTitle)} />
              </Route>
      Severity: Major
      Found in src/applications/vaos/covid-19-vaccine/index.jsx and 10 other locations - About 1 hr to fix
      src/applications/vaos/covid-19-vaccine/index.jsx on lines 126..128
      src/applications/vaos/covid-19-vaccine/index.jsx on lines 187..189
      src/applications/vaos/new-appointment/index.jsx on lines 84..86
      src/applications/vaos/new-appointment/index.jsx on lines 95..97
      src/applications/vaos/new-appointment/index.jsx on lines 98..100
      src/applications/vaos/new-appointment/index.jsx on lines 101..105
      src/applications/vaos/new-appointment/index.jsx on lines 106..108
      src/applications/vaos/new-appointment/index.jsx on lines 109..111
      src/applications/vaos/new-appointment/index.jsx on lines 118..120
      src/applications/vaos/new-appointment/index.jsx on lines 155..157

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 55.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 11 locations. Consider refactoring.
      Open

              <Route path={`${match.url}`}>
                <PlanAheadPage changeCrumb={newTitle => setCrumb(newTitle)} />
              </Route>
      Severity: Major
      Found in src/applications/vaos/covid-19-vaccine/index.jsx and 10 other locations - About 1 hr to fix
      src/applications/vaos/covid-19-vaccine/index.jsx on lines 126..128
      src/applications/vaos/covid-19-vaccine/index.jsx on lines 174..176
      src/applications/vaos/new-appointment/index.jsx on lines 84..86
      src/applications/vaos/new-appointment/index.jsx on lines 95..97
      src/applications/vaos/new-appointment/index.jsx on lines 98..100
      src/applications/vaos/new-appointment/index.jsx on lines 101..105
      src/applications/vaos/new-appointment/index.jsx on lines 106..108
      src/applications/vaos/new-appointment/index.jsx on lines 109..111
      src/applications/vaos/new-appointment/index.jsx on lines 118..120
      src/applications/vaos/new-appointment/index.jsx on lines 155..157

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 55.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 11 locations. Consider refactoring.
      Open

              <Route path={`${match.url}/contact-facility`}>
                <ContactFacilitiesPage changeCrumb={newTitle => setCrumb(newTitle)} />
              </Route>
      Severity: Major
      Found in src/applications/vaos/covid-19-vaccine/index.jsx and 10 other locations - About 1 hr to fix
      src/applications/vaos/covid-19-vaccine/index.jsx on lines 174..176
      src/applications/vaos/covid-19-vaccine/index.jsx on lines 187..189
      src/applications/vaos/new-appointment/index.jsx on lines 84..86
      src/applications/vaos/new-appointment/index.jsx on lines 95..97
      src/applications/vaos/new-appointment/index.jsx on lines 98..100
      src/applications/vaos/new-appointment/index.jsx on lines 101..105
      src/applications/vaos/new-appointment/index.jsx on lines 106..108
      src/applications/vaos/new-appointment/index.jsx on lines 109..111
      src/applications/vaos/new-appointment/index.jsx on lines 118..120
      src/applications/vaos/new-appointment/index.jsx on lines 155..157

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 55.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status