department-of-veterans-affairs/vets-website

Function updateSchema has 93 lines of code (exceeds 25 allowed). Consider refactoring.

Open

      const updateSchema = () => {
        if (addressFormData) {
          // if livesOnMilitaryBase is checked
          if (addressFormData?.['view:livesOnMilitaryBase']) {
            const filteredRequiredArray = addressFormRequiredData.filter(

File ChangeOfAddressForm.jsx has 260 lines of code (exceeds 250 allowed). Consider refactoring.

Open

import React, { useEffect, useState } from 'react';
import PropTypes from 'prop-types';
import ADDRESS_DATA from 'platform/forms/address/data';
import { validateAsciiCharacters } from 'platform/user/profile/vap-svc/util';
import SchemaForm from '@department-of-veterans-affairs/platform-forms-system/SchemaForm';

Identical blocks of code found in 2 locations. Consider refactoring.

Open

            if (
              formData?.countryCodeIso3 === undefined ||
              formData?.countryCodeIso3 === 'USA'
            ) {
              setAddressSchema(

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

  const city = {
    title: 'city',
    addressSchema: {
      type: 'string',
      pattern: blockURLsRegEx,

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

ChangeOfAddressForm.propTypes = {
  addressFormData: PropTypes.object.isRequired,
  formChange: PropTypes.func.isRequired,
  formData: PropTypes.object.isRequired,
  formSubmit: PropTypes.func.isRequired,

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

  const addObjectKeys = (
    originalObject,
    keysToAdd,
    valuesToAdd,
    schemaType,

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

  const createFormSchema = (requiredArray = []) => {
    const fSchema = getFormSchema(formData);

    if (requiredArray.size === 0) {
      return fSchema;

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

  const removeObjectKeys = (originalObject, keysToRemove, schemaType) => {
    // Clone the originals object to avoid mutating it
    const newObject = { ...originalObject };

    // Iterate over the keysToRemove array

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

  const stateCode = {
    title: 'stateCode',
    addressSchema: {
      type: 'string',
      enum: Object.keys(MILITARY_STATES),

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  return (
    <SchemaForm
      addNameAttribute
      name="Contact Information"
      // title is required by the SchemaForm and used internally

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

  const countryCode = {
    title: 'countryCodeIso3',
    addressSchema: {
      type: 'string',
      enum: ['USA'],

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

            const tempUISchemaAddObj = addObjectKeys(
              getUiSchema(),
              [countryCode.title, city.title, stateCode.title],
              [
                countryCode.addressUISchema,

• Read up
  Read up