Sign upLogin

department-of-veterans-affairs/vets-website

View on GitHub
Star
src/platform/forms-system/src/js/patterns/array-builder/arrayBuilder.jsx

Summary

Maintainability
F
3 days
Test Coverage

Function arrayBuilderPages has 234 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function arrayBuilderPages(options, pageBuilderCallback) {
  let introPath;
  let summaryPath;
  let hasItemsKey;
  const itemPages = [];
Severity: Major
Found in src/platform/forms-system/src/js/patterns/array-builder/arrayBuilder.jsx - About 1 day to fix

    File arrayBuilder.jsx has 398 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /* eslint-disable no-unused-vars */
import { getNextPagePath } from 'platform/forms-system/src/js/routing';
import {
  createArrayBuilderItemAddPath,
  onNavForwardKeepUrlParams,
    Severity: Minor
    Found in src/platform/forms-system/src/js/patterns/array-builder/arrayBuilder.jsx - About 5 hrs to fix

      Function arrayBuilderPages has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
      Open

      export function arrayBuilderPages(options, pageBuilderCallback) {
  let introPath;
  let summaryPath;
  let hasItemsKey;
  const itemPages = [];
      Severity: Minor
      Found in src/platform/forms-system/src/js/patterns/array-builder/arrayBuilder.jsx - About 5 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function validatePages has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

      export function validatePages(orderedPageTypes) {
  const pageTypes = {};
  for (const pageType of orderedPageTypes) {
    if (pageType === 'intro') {
      if (pageTypes.intro || pageTypes.summary || pageTypes.item) {
      Severity: Minor
      Found in src/platform/forms-system/src/js/patterns/array-builder/arrayBuilder.jsx - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function itemPage has 38 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        pageBuilder.itemPage = pageConfig => {
    const requiredOpts = ['title', 'path', 'uiSchema', 'schema'];
    verifyRequiredPropsPageConfig('itemPage', requiredOpts, pageConfig);
    const { onNavBack, onNavForward } = getNavItem(pageConfig.path);
      Severity: Minor
      Found in src/platform/forms-system/src/js/patterns/array-builder/arrayBuilder.jsx - About 1 hr to fix

        Function validatePages has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        export function validatePages(orderedPageTypes) {
  const pageTypes = {};
  for (const pageType of orderedPageTypes) {
    if (pageType === 'intro') {
      if (pageTypes.intro || pageTypes.summary || pageTypes.item) {
        Severity: Minor
        Found in src/platform/forms-system/src/js/patterns/array-builder/arrayBuilder.jsx - About 1 hr to fix

          Function summaryPage has 28 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            pageBuilder.summaryPage = pageConfig => {
    const requiredOpts = ['title', 'path', 'uiSchema', 'schema'];
    verifyRequiredPropsPageConfig('summaryPage', requiredOpts, pageConfig);

    const summaryPageProps = {
          Severity: Minor
          Found in src/platform/forms-system/src/js/patterns/array-builder/arrayBuilder.jsx - About 1 hr to fix

            Function determineYesNoField has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

            function determineYesNoField(uiSchema) {
  let yesNoKey;
  if (uiSchema) {
    for (const key of Object.keys(uiSchema)) {
      if (
            Severity: Minor
            Found in src/platform/forms-system/src/js/patterns/array-builder/arrayBuilder.jsx - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 5 locations. Consider refactoring.
            Open

                const summaryPageProps = {
      arrayPath,
      hasItemsKey,
      firstItemPagePath,
      getText,
            Severity: Major
            Found in src/platform/forms-system/src/js/patterns/array-builder/arrayBuilder.jsx and 4 other locations - About 1 hr to fix
            src/applications/ask-va/config/schema-helpers/formFlowHelper.js on lines 435..446
            src/applications/claims-status/components/claim-files-tab/AdditionalEvidencePage.jsx on lines 217..228
            src/applications/facility-locator/containers/FacilitiesMap.jsx on lines 705..716
            src/applications/appeals/shared/props.js on lines 65..76

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 58.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status