Sign upLogin

department-of-veterans-affairs/vets-website

View on GitHub
Star
src/platform/forms-system/src/js/web-component-patterns/datePatterns.jsx

Summary

Maintainability
C
1 day
Test Coverage

Function currentOrPastDateUI has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const currentOrPastDateUI = options => {
  const { title, errorMessages, required, ...uiOptions } =
    typeof options === 'object' ? options : { title: options };

  // if monthYearOnly is used, the schema pattern also needs
Severity: Minor
Found in src/platform/forms-system/src/js/web-component-patterns/datePatterns.jsx - About 1 hr to fix

    Function currentOrPastDateRangeUI has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    const currentOrPastDateRangeUI = (fromOptions, toOptions, errorMessage) => {
  let fromLabel = 'From date';
  let toLabel = 'To date';
  let fromCustomOptions = {};
  let toCustomOptions = {};
    Severity: Minor
    Found in src/platform/forms-system/src/js/web-component-patterns/datePatterns.jsx - About 1 hr to fix

      Consider simplifying this complex logical expression.
      Open

        if (typeof fromOptions === 'object' && typeof toOptions === 'object') {
    // Extract custom options
    fromLabel = fromOptions.title || fromLabel;
    toLabel = toOptions.title || toLabel;
    fromCustomOptions = { ...fromOptions };
      Severity: Major
      Found in src/platform/forms-system/src/js/web-component-patterns/datePatterns.jsx - About 40 mins to fix

        Function currentOrPastDateUI has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        const currentOrPastDateUI = options => {
  const { title, errorMessages, required, ...uiOptions } =
    typeof options === 'object' ? options : { title: options };

  // if monthYearOnly is used, the schema pattern also needs
        Severity: Minor
        Found in src/platform/forms-system/src/js/web-component-patterns/datePatterns.jsx - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function currentOrPastDateRangeUI has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

        const currentOrPastDateRangeUI = (fromOptions, toOptions, errorMessage) => {
  let fromLabel = 'From date';
  let toLabel = 'To date';
  let fromCustomOptions = {};
  let toCustomOptions = {};
        Severity: Minor
        Found in src/platform/forms-system/src/js/web-component-patterns/datePatterns.jsx - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        const dateOfBirthUI = options => {
  const { title, ...uiOptions } =
    typeof options === 'object' ? options : { title: options };

  return currentOrPastDateUI({
        Severity: Major
        Found in src/platform/forms-system/src/js/web-component-patterns/datePatterns.jsx and 1 other location - About 2 hrs to fix
        src/platform/forms-system/src/js/web-component-patterns/datePatterns.jsx on lines 305..317

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 87.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        const dateOfDeathUI = options => {
  const { title, ...uiOptions } =
    typeof options === 'object' ? options : { title: options };

  return currentOrPastDateUI({
        Severity: Major
        Found in src/platform/forms-system/src/js/web-component-patterns/datePatterns.jsx and 1 other location - About 2 hrs to fix
        src/platform/forms-system/src/js/web-component-patterns/datePatterns.jsx on lines 274..286

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 87.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

        export {
  currentOrPastDateUI,
  currentOrPastDateDigitsUI,
  currentOrPastDateRangeUI,
  currentOrPastMonthYearDateUI,
        Severity: Major
        Found in src/platform/forms-system/src/js/web-component-patterns/datePatterns.jsx and 2 other locations - About 1 hr to fix
        src/applications/disability-benefits/686c-674-v2/config/utilities.js on lines 86..101
        src/applications/disability-benefits/686c-674/config/utilities.js on lines 85..100

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 72.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status