Sign upLogin

department-of-veterans-affairs/vets-website

View on GitHub
Star
src/platform/user/authorization/containers/MHVApp.jsx

Summary

Maintainability
D
2 days
Test Coverage

File MHVApp.jsx has 330 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import PropTypes from 'prop-types';
import React from 'react';
import { connect } from 'react-redux';
import { withRouter } from 'react-router';
import appendQuery from 'append-query';
Severity: Minor
Found in src/platform/user/authorization/containers/MHVApp.jsx - About 3 hrs to fix

    Function render has 48 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      render() {
    const {
      accountLevel,
      accountState,
      errors,
    Severity: Minor
    Found in src/platform/user/authorization/containers/MHVApp.jsx - About 1 hr to fix

      Function render has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

        render() {
    const {
      accountLevel,
      accountState,
      errors,
      Severity: Minor
      Found in src/platform/user/authorization/containers/MHVApp.jsx - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this function.
      Open

            return this.renderUpgradeFailedMessage();
      Severity: Major
      Found in src/platform/user/authorization/containers/MHVApp.jsx - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return (
          <va-loading-indicator set-focus message="Redirecting to verify..." />
        );
        Severity: Major
        Found in src/platform/user/authorization/containers/MHVApp.jsx - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

              return (
      <div>
        {this.renderTcAcceptanceMessage()}
        {this.props.children}
      </div>
          Severity: Major
          Found in src/platform/user/authorization/containers/MHVApp.jsx - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                  return this.renderIneligibleMessage(accountState);
            Severity: Major
            Found in src/platform/user/authorization/containers/MHVApp.jsx - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                    return mhvAccessError;
              Severity: Major
              Found in src/platform/user/authorization/containers/MHVApp.jsx - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                        return (
          <va-loading-indicator
            set-focus
            message="Redirecting to terms and conditions..."
          />
                Severity: Major
                Found in src/platform/user/authorization/containers/MHVApp.jsx - About 30 mins to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                    renderRegisterFailedMessage = () => {
    const alertProps = {
      headline: `We can’t give you access to VA.gov health tools right now`,
      content: (
        <p>
                  Severity: Major
                  Found in src/platform/user/authorization/containers/MHVApp.jsx and 1 other location - About 3 hrs to fix
                  src/platform/user/authorization/containers/MHVApp.jsx on lines 267..289

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 98.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                    renderUpgradeFailedMessage = () => {
    const alertProps = {
      headline: `We can’t give you access to VA.gov health tools right now`,
      content: (
        <p>
                  Severity: Major
                  Found in src/platform/user/authorization/containers/MHVApp.jsx and 1 other location - About 3 hrs to fix
                  src/platform/user/authorization/containers/MHVApp.jsx on lines 246..265

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 98.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                    has_deactivated_mhv_ids: {
    headline: (
      <span>It looks like you’ve disabled your My HealtheVet account</span>
    ),
    content: (
                  Severity: Major
                  Found in src/platform/user/authorization/containers/MHVApp.jsx and 1 other location - About 2 hrs to fix
                  src/platform/user/authorization/containers/MHVApp.jsx on lines 78..97

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 83.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                    has_multiple_active_mhv_ids: {
    headline: (
      <span>It looks like you have more than one My HealtheVet account</span>
    ),
    content: (
                  Severity: Major
                  Found in src/platform/user/authorization/containers/MHVApp.jsx and 1 other location - About 2 hrs to fix
                  src/platform/user/authorization/containers/MHVApp.jsx on lines 57..76

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 83.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                    needs_ssn_resolution: {
    headline: `We can’t give you access to the VA.gov health tools`,
    content: (
      <div>
        <p>
                  Severity: Major
                  Found in src/platform/user/authorization/containers/MHVApp.jsx and 1 other location - About 1 hr to fix
                  src/platform/user/authorization/containers/MHVApp.jsx on lines 40..55

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 58.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                    needs_va_patient: {
    headline: `We can’t give you access to the VA.gov health tools`,
    content: (
      <div>
        <p>
                  Severity: Major
                  Found in src/platform/user/authorization/containers/MHVApp.jsx and 1 other location - About 1 hr to fix
                  src/platform/user/authorization/containers/MHVApp.jsx on lines 18..38

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 58.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status