department-of-veterans-affairs/vets-website

View on GitHub
src/platform/user/profile/vap-svc/components/ContactInformationFieldInfo/ConfirmCancelModal.jsx

Summary

Maintainability
B
4 hrs
Test Coverage

Function ConfirmCancelModal has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const ConfirmCancelModal = props => {
  const { activeSection, closeModal, onHide, isVisible } = props;

  // return null to avoid even having the web component in dom
  // when not needed (this makes testing easier as well)

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        <VaModal
          modalTitle="Cancel changes?"
          status="warning"
          visible={isVisible}
          onCloseEvent={onHide}
    src/applications/personalization/profile/components/edit/EditConfirmCancelModal.jsx on lines 26..41

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 69.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 11 locations. Consider refactoring.
    Open

    ConfirmCancelModal.propTypes = {
      closeModal: PropTypes.func.isRequired,
      isVisible: PropTypes.bool.isRequired,
      onHide: PropTypes.func.isRequired,
      activeSection: PropTypes.string,
    src/applications/check-in/travel-claim/pages/travel-mileage/MultiAppointmentBody.jsx on lines 64..69
    src/applications/claims-status/components/appeals-v2/PastEvent.jsx on lines 18..23
    src/applications/claims-status/components/claim-files-tab/RemoveFileModal.jsx on lines 40..45
    src/applications/claims-status/components/claim-overview-tab/ClaimPhaseStepper.jsx on lines 243..248
    src/applications/financial-status-report/components/employment/SpouseEmploymentHistoryWidget.jsx on lines 79..84
    src/applications/financial-status-report/components/householdIncome/GrossMonthlyIncomeInput.jsx on lines 197..202
    src/applications/financial-status-report/components/householdIncome/PayrollDeductionInputList.jsx on lines 245..250
    src/applications/financial-status-report/components/householdIncome/SpouseGrossMonthlyIncomeInput.jsx on lines 199..204
    src/applications/yellow-ribbon/components/SearchResultsPage/index.js on lines 83..88
    src/applications/check-in/components/ActionLink.jsx on lines 51..56

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 60.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status