department-of-veterans-affairs/vets-website

View on GitHub
src/platform/user/profile/vap-svc/components/ProfileInformationView.jsx

Summary

Maintainability
B
6 hrs
Test Coverage

Function ProfileInformationView has 61 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const ProfileInformationView = props => {
  const { data, fieldName, title, id } = props;

  const titleLower = title.toLowerCase();

    Function ProfileInformationView has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

    const ProfileInformationView = props => {
      const { data, fieldName, title, id } = props;
    
      const titleLower = title.toLowerCase();
    
    

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

      return null;
    Severity: Major
    Found in src/platform/user/profile/vap-svc/components/ProfileInformationView.jsx - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

          if (fieldName === FIELD_NAMES.PREFERRED_NAME) return data[fieldName];
      Severity: Major
      Found in src/platform/user/profile/vap-svc/components/ProfileInformationView.jsx - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

              return formatGenderIdentity(data[fieldName]);
        Severity: Major
        Found in src/platform/user/profile/vap-svc/components/ProfileInformationView.jsx - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

              return formatMultiSelectAndText(data, fieldName) || unsetFieldTitleSpan;
          Severity: Major
          Found in src/platform/user/profile/vap-svc/components/ProfileInformationView.jsx - About 30 mins to fix

            There are no issues that match your filters.

            Category
            Status