Sign upLogin

deployphp/deployer

View on GitHub
Star
src/Task/ScriptManager.php

Summary

Maintainability
C
7 hrs
Test Coverage

Function getTasks has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

    public function getTasks(string $name, ?string $startFrom = null, array &$skipped = []): array
    {
        $tasks = [];
        $this->visitedTasks = [];
        $allTasks = $this->doGetTasks($name);
Severity: Minor
Found in src/Task/ScriptManager.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function doGetTasks has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

    public function doGetTasks(string $name): array
    {
        if (array_key_exists($name, $this->visitedTasks)) {
            if ($this->visitedTasks[$name] >= 100) {
                throw new Exception("Looks like a circular dependency with \"$name\" task.");
Severity: Minor
Found in src/Task/ScriptManager.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method doGetTasks has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function doGetTasks(string $name): array
    {
        if (array_key_exists($name, $this->visitedTasks)) {
            if ($this->visitedTasks[$name] >= 100) {
                throw new Exception("Looks like a circular dependency with \"$name\" task.");
Severity: Minor
Found in src/Task/ScriptManager.php - About 1 hr to fix

    Method getTasks has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function getTasks(string $name, ?string $startFrom = null, array &$skipped = []): array
    {
        $tasks = [];
        $this->visitedTasks = [];
        $allTasks = $this->doGetTasks($name);
    Severity: Minor
    Found in src/Task/ScriptManager.php - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status