Sign upLogin

derwentx/Xero-Map-Generator

View on GitHub
Star
xero_map_gen/core.py

Summary

Maintainability
A
2 hrs
Test Coverage

Function get_map_contacts has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

def get_map_contacts(conf):
    xero = XeroApiWrapper(**dict(conf.XeroApiConfig))
    map_contact_groups = conf.FilterConfig.get('contact_groups', '').split('|')
    PKG_LOGGER.debug("map contact groups: %s", map_contact_groups)
    contact_limit = conf.BaseConfig.contact_limit or None
Severity: Minor
Found in xero_map_gen/core.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Refactor this function to reduce its Cognitive Complexity from 19 to the 15 allowed.
Open

def get_map_contacts(conf):
Severity: Critical
Found in xero_map_gen/core.py by sonar-python

Cognitive Complexity is a measure of how hard the control flow of a function is to understand. Functions with high Cognitive Complexity will be difficult to maintain.

See

There are no issues that match your filters.

Category
Status