detain/db_abstraction

View on GitHub
src/Loader.php

Summary

Maintainability
A
3 hrs
Test Coverage

Method __construct has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function __construct($Type = '', $database = '', $user = '', $password = '', $host = 'localhost', $query = '')
    {
        $this->Type = $Type;
        if (!defined('db')) {
            switch ($this->Type) {
Severity: Minor
Found in src/Loader.php - About 1 hr to fix

    Function __construct has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        public function __construct($Type = '', $database = '', $user = '', $password = '', $host = 'localhost', $query = '')
        {
            $this->Type = $Type;
            if (!defined('db')) {
                switch ($this->Type) {
    Severity: Minor
    Found in src/Loader.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public function __construct($Type = '', $database = '', $user = '', $password = '', $host = 'localhost', $query = '')
    Severity: Minor
    Found in src/Loader.php - About 45 mins to fix

      Function halt has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public function halt($msg, $line = '', $file = '')
          {
              $this->unlock(false);
      
              if ($this->haltOnError == 'no') {
      Severity: Minor
      Found in src/Loader.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      FIXME found
      Open

                  // FIXME! Add check for error levels
      Severity: Minor
      Found in src/Loader.php by fixme

      The parameter $Type is not named in camelCase.
      Open

          public function __construct($Type = '', $database = '', $user = '', $password = '', $host = 'localhost', $query = '')
          {
              $this->Type = $Type;
              if (!defined('db')) {
                  switch ($this->Type) {
      Severity: Minor
      Found in src/Loader.php by phpmd

      CamelCaseParameterName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name parameters.

      Example

      class ClassName {
          public function doSomething($user_name) {
          }
      }

      Source

      The variable $Type is not named in camelCase.
      Open

          public function __construct($Type = '', $database = '', $user = '', $password = '', $host = 'localhost', $query = '')
          {
              $this->Type = $Type;
              if (!defined('db')) {
                  switch ($this->Type) {
      Severity: Minor
      Found in src/Loader.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      There are no issues that match your filters.

      Category
      Status