detain/myadmin-abuse-plugin

View on GitHub
src/abuse.php

Summary

Maintainability
C
1 day
Test Coverage

Function abuse has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
Open

function abuse()
{
    /*
    CREATE TABLE my.abuse (
    abuse_id int(11) UNSIGNED NOT NULL AUTO_INCREMENT,
Severity: Minor
Found in src/abuse.php - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method abuse has 75 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function abuse()
{
    /*
    CREATE TABLE my.abuse (
    abuse_id int(11) UNSIGNED NOT NULL AUTO_INCREMENT,
Severity: Major
Found in src/abuse.php - About 3 hrs to fix

    Consider simplifying this complex logical expression.
    Open

                    if (($logged_in && $GLOBALS['tf']->accounts->data['account_lid'] == $server_data['email']) || ($logged_in && $GLOBALS['tf']->accounts->data['account_lid'] == $db->Record['abuse_lid']) || ($logged_in == false) || ($GLOBALS['tf']->ima == 'admin')) {
                        if (isset($GLOBALS['tf']->variables->request['response'])) {
                            $db->query("update abuse set abuse_status='" . $db->real_escape($GLOBALS['tf']->variables->request['response_status']) . "' where abuse_id={$id}", __LINE__, __FILE__);
                            $db->query("update abuse_data set abuse_response='" . $db->real_escape($GLOBALS['tf']->variables->request['response']) . "' where abuse_id={$id}", __LINE__, __FILE__);
                            $db->query("select * from abuse left join abuse_data using (abuse_id) where abuse_id={$id}");
    Severity: Major
    Found in src/abuse.php - About 1 hr to fix

      The function abuse() has a Cyclomatic Complexity of 22. The configured cyclomatic complexity threshold is 10.
      Open

      function abuse()
      {
          /*
          CREATE TABLE my.abuse (
          abuse_id int(11) UNSIGNED NOT NULL AUTO_INCREMENT,
      Severity: Minor
      Found in src/abuse.php by phpmd

      CyclomaticComplexity

      Since: 0.1

      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

      Example

      // Cyclomatic Complexity = 11
      class Foo {
      1   public function example() {
      2       if ($a == $b) {
      3           if ($a1 == $b1) {
                      fiddle();
      4           } elseif ($a2 == $b2) {
                      fiddle();
                  } else {
                      fiddle();
                  }
      5       } elseif ($c == $d) {
      6           while ($c == $d) {
                      fiddle();
                  }
      7        } elseif ($e == $f) {
      8           for ($n = 0; $n < $h; $n++) {
                      fiddle();
                  }
              } else {
                  switch ($z) {
      9               case 1:
                          fiddle();
                          break;
      10              case 2:
                          fiddle();
                          break;
      11              case 3:
                          fiddle();
                          break;
                      default:
                          fiddle();
                          break;
                  }
              }
          }
      }

      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

      Missing class import via use statement (line '67', column '23').
      Open

              $smarty = new TFSmarty();
      Severity: Minor
      Found in src/abuse.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
          return new \stdClass();
      }

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      The variable $logged_in is not named in camelCase.
      Open

      function abuse()
      {
          /*
          CREATE TABLE my.abuse (
          abuse_id int(11) UNSIGNED NOT NULL AUTO_INCREMENT,
      Severity: Minor
      Found in src/abuse.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $server_data is not named in camelCase.
      Open

      function abuse()
      {
          /*
          CREATE TABLE my.abuse (
          abuse_id int(11) UNSIGNED NOT NULL AUTO_INCREMENT,
      Severity: Minor
      Found in src/abuse.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $logged_in is not named in camelCase.
      Open

      function abuse()
      {
          /*
          CREATE TABLE my.abuse (
          abuse_id int(11) UNSIGNED NOT NULL AUTO_INCREMENT,
      Severity: Minor
      Found in src/abuse.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $logged_in is not named in camelCase.
      Open

      function abuse()
      {
          /*
          CREATE TABLE my.abuse (
          abuse_id int(11) UNSIGNED NOT NULL AUTO_INCREMENT,
      Severity: Minor
      Found in src/abuse.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $server_data is not named in camelCase.
      Open

      function abuse()
      {
          /*
          CREATE TABLE my.abuse (
          abuse_id int(11) UNSIGNED NOT NULL AUTO_INCREMENT,
      Severity: Minor
      Found in src/abuse.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $logged_in is not named in camelCase.
      Open

      function abuse()
      {
          /*
          CREATE TABLE my.abuse (
          abuse_id int(11) UNSIGNED NOT NULL AUTO_INCREMENT,
      Severity: Minor
      Found in src/abuse.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $server_data is not named in camelCase.
      Open

      function abuse()
      {
          /*
          CREATE TABLE my.abuse (
          abuse_id int(11) UNSIGNED NOT NULL AUTO_INCREMENT,
      Severity: Minor
      Found in src/abuse.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $logged_in is not named in camelCase.
      Open

      function abuse()
      {
          /*
          CREATE TABLE my.abuse (
          abuse_id int(11) UNSIGNED NOT NULL AUTO_INCREMENT,
      Severity: Minor
      Found in src/abuse.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $server_data is not named in camelCase.
      Open

      function abuse()
      {
          /*
          CREATE TABLE my.abuse (
          abuse_id int(11) UNSIGNED NOT NULL AUTO_INCREMENT,
      Severity: Minor
      Found in src/abuse.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      The variable $logged_in is not named in camelCase.
      Open

      function abuse()
      {
          /*
          CREATE TABLE my.abuse (
          abuse_id int(11) UNSIGNED NOT NULL AUTO_INCREMENT,
      Severity: Minor
      Found in src/abuse.php by phpmd

      CamelCaseVariableName

      Since: 0.2

      It is considered best practice to use the camelCase notation to name variables.

      Example

      class ClassName {
          public function doSomething() {
              $data_module = new DataModule();
          }
      }

      Source

      There are no issues that match your filters.

      Category
      Status