Sign upLogin

detain/myadmin-amazon-payments

View on GitHub
Star

Showing 2 of 2 total issues

Avoid unused local variables such as '$menu'.
Open

        $menu = $event->getSubject();
Severity: Minor
Found in src/Plugin.php by phpmd

UnusedLocalVariable

Since: 0.2

Detects when a local variable is declared and/or assigned, but not used.

Example

class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

The function amazon_obtain_profile() contains an exit expression.
Open

            exit;
Severity: Minor
Found in src/amazon.php by phpmd

ExitExpression

Since: 0.2

An exit-expression within regular code is untestable and therefore it should be avoided. Consider to move the exit-expression into some kind of startup script where an error/exception code is returned to the calling environment.

Example

class Foo {
    public function bar($param)  {
        if ($param === 42) {
            exit(23);
        }
    }
}

Source https://phpmd.org/rules/design.html#exitexpression

Severity
Category
Status
Source
Language