detain/myadmin-cpanel-licensing

View on GitHub
src/cpanel_kcare_addon.php

Summary

Maintainability
A
3 hrs
Test Coverage

Function cpanel_kcare_addon has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

function cpanel_kcare_addon()
{
    page_title('CPanel KCare Addon');
    $settings = \get_module_settings('licenses');
    $db = get_module_db('licenses');
Severity: Minor
Found in src/cpanel_kcare_addon.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method cpanel_kcare_addon has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function cpanel_kcare_addon()
{
    page_title('CPanel KCare Addon');
    $settings = \get_module_settings('licenses');
    $db = get_module_db('licenses');
Severity: Minor
Found in src/cpanel_kcare_addon.php - About 1 hr to fix

    Remove error control operator '@' on line 48.
    Open

    function cpanel_kcare_addon()
    {
        page_title('CPanel KCare Addon');
        $settings = \get_module_settings('licenses');
        $db = get_module_db('licenses');
    Severity: Minor
    Found in src/cpanel_kcare_addon.php by phpmd

    ErrorControlOperator

    Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

    Example

    function foo($filePath) {
        $file = @fopen($filPath); // hides exceptions
        $key = @$array[$notExistingKey]; // assigns null to $key
    }

    Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

    Missing class import via use statement (line '38', column '26').
    Open

                $table = new \TFTable();
    Severity: Minor
    Found in src/cpanel_kcare_addon.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '52', column '23').
    Open

                $cl = new \Detain\Cloudlinux\Cloudlinux(CLOUDLINUX_LOGIN, CLOUDLINUX_KEY);
    Severity: Minor
    Found in src/cpanel_kcare_addon.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    There are no issues that match your filters.

    Category
    Status