Sign upLogin

detain/myadmin-cpanel-licensing

View on GitHub
Star
src/unbilled_cpanel.php

Summary

Maintainability
F
3 days
Test Coverage

Function unbilled_cpanel has a Cognitive Complexity of 133 (exceeds 5 allowed). Consider refactoring.
Open

function unbilled_cpanel()
{
    function_requirements('has_acl');
    if ($GLOBALS['tf']->ima != 'admin' || !has_acl('view_service')) {
        dialog('Not admin', 'Not Admin or you lack the permissions to view this page.');
Severity: Minor
Found in src/unbilled_cpanel.php - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method unbilled_cpanel has 202 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function unbilled_cpanel()
{
    function_requirements('has_acl');
    if ($GLOBALS['tf']->ima != 'admin' || !has_acl('view_service')) {
        dialog('Not admin', 'Not Admin or you lack the permissions to view this page.');
Severity: Major
Found in src/unbilled_cpanel.php - About 1 day to fix

    Missing class import via use statement (line '45', column '16').
    Open

        $cpl = new \Detain\Cpanel\Cpanel(CPANEL_LICENSING_USERNAME, CPANEL_LICENSING_PASSWORD);
    Severity: Minor
    Found in src/unbilled_cpanel.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '31', column '26').
    Open

                $table = new \TFTable();
    Severity: Minor
    Found in src/unbilled_cpanel.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    There are no issues that match your filters.

    Category
    Status