detain/myadmin-fantastico-licensing

View on GitHub
src/reusable_fantastico.php

Summary

Maintainability
B
4 hrs
Test Coverage

Function reusable_fantastico has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

function reusable_fantastico()
{
    page_title('ReUsable Fantastico Licenses');
    if ($GLOBALS['tf']->ima == 'admin') {
        $module = 'licenses';
Severity: Minor
Found in src/reusable_fantastico.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method reusable_fantastico has 51 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function reusable_fantastico()
{
    page_title('ReUsable Fantastico Licenses');
    if ($GLOBALS['tf']->ima == 'admin') {
        $module = 'licenses';
Severity: Major
Found in src/reusable_fantastico.php - About 2 hrs to fix

    Missing class import via use statement (line '63', column '22').
    Open

            $table = new \TFTable();
    Severity: Minor
    Found in src/reusable_fantastico.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Avoid unused local variables such as '$frequency'.
    Open

            $frequency = 1;
    Severity: Minor
    Found in src/reusable_fantastico.php by phpmd

    UnusedLocalVariable

    Since: 0.2

    Detects when a local variable is declared and/or assigned, but not used.

    Example

    class Foo {
        public function doSomething()
        {
            $i = 5; // Unused
        }
    }

    Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

    Avoid unused local variables such as '$serviceCost'.
    Open

                        $serviceCost = $serviceTypes[$type]['services_cost'];
    Severity: Minor
    Found in src/reusable_fantastico.php by phpmd

    UnusedLocalVariable

    Since: 0.2

    Detects when a local variable is declared and/or assigned, but not used.

    Example

    class Foo {
        public function doSomething()
        {
            $i = 5; // Unused
        }
    }

    Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

    There are no issues that match your filters.

    Category
    Status