Sign upLogin

detain/myadmin-hd-vps-addon

View on GitHub
Star

Showing 39 of 39 total issues

Function vps_hdspace has a Cognitive Complexity of 52 (exceeds 5 allowed). Consider refactoring.
Open

function vps_hdspace()
{
    $module = 'vps';
    $settings = get_module_settings($module);
    page_title('Purchase Additional VPS HD Space');
Severity: Minor
Found in src/vps_hdspace.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method vps_hdspace has 192 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function vps_hdspace()
{
    $module = 'vps';
    $settings = get_module_settings($module);
    page_title('Purchase Additional VPS HD Space');
Severity: Major
Found in src/vps_hdspace.php - About 7 hrs to fix

    Missing class import via use statement (line '103', column '14').
    Open

            (new \MyAdmin\Mail())->adminMail($subject, $email, false, 'admin/vps_hdspace_canceled.tpl');
    Severity: Minor
    Found in src/Plugin.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '165', column '36').
    Open

                        $invoice = new \MyAdmin\Orm\Invoice($db);
    Severity: Minor
    Found in src/vps_hdspace.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '36', column '18').
    Open

        $table = new TFTable();
    Severity: Minor
    Found in src/vps_hdspace.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '81', column '28').
    Open

        $service_invoice = new \MyAdmin\Orm\Repeat_Invoice($db);
    Severity: Minor
    Found in src/vps_hdspace.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '61', column '22').
    Open

            $addon = new \AddonHandler();
    Severity: Minor
    Found in src/Plugin.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '61', column '27').
    Open

        $repeat_invoice = new \MyAdmin\Orm\Repeat_Invoice($db);
    Severity: Minor
    Found in src/vps_hdspace.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '178', column '43').
    Open

                        $repeat_invoice = new \MyAdmin\Orm\Repeat_Invoice($db);
    Severity: Minor
    Found in src/vps_hdspace.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Avoid unused local variables such as '$rinv'.
    Open

            $rinv = $repeat_invoice->get_raw_row();
    Severity: Minor
    Found in src/vps_hdspace.php by phpmd

    UnusedLocalVariable

    Since: 0.2

    Detects when a local variable is declared and/or assigned, but not used.

    Example

    class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

    Avoid unused local variables such as '$db2'.
    Open

        $db2 = clone $db;
    Severity: Minor
    Found in src/vps_hdspace.php by phpmd

    UnusedLocalVariable

    Since: 0.2

    Detects when a local variable is declared and/or assigned, but not used.

    Example

    class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

    The variable $service_invoice is not named in camelCase.
    Open

    function vps_hdspace()
{
    $module = 'vps';
    $settings = get_module_settings($module);
    page_title('Purchase Additional VPS HD Space');
    Severity: Minor
    Found in src/vps_hdspace.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $repeat_invoices is not named in camelCase.
    Open

    function vps_hdspace()
{
    $module = 'vps';
    $settings = get_module_settings($module);
    page_title('Purchase Additional VPS HD Space');
    Severity: Minor
    Found in src/vps_hdspace.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $repeat_invoice is not named in camelCase.
    Open

    function vps_hdspace()
{
    $module = 'vps';
    $settings = get_module_settings($module);
    page_title('Purchase Additional VPS HD Space');
    Severity: Minor
    Found in src/vps_hdspace.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $new_date is not named in camelCase.
    Open

    function vps_hdspace()
{
    $module = 'vps';
    $settings = get_module_settings($module);
    page_title('Purchase Additional VPS HD Space');
    Severity: Minor
    Found in src/vps_hdspace.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $service_date is not named in camelCase.
    Open

    function vps_hdspace()
{
    $module = 'vps';
    $settings = get_module_settings($module);
    page_title('Purchase Additional VPS HD Space');
    Severity: Minor
    Found in src/vps_hdspace.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $repeat_invoice is not named in camelCase.
    Open

    function vps_hdspace()
{
    $module = 'vps';
    $settings = get_module_settings($module);
    page_title('Purchase Additional VPS HD Space');
    Severity: Minor
    Found in src/vps_hdspace.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $service_invoice is not named in camelCase.
    Open

    function vps_hdspace()
{
    $module = 'vps';
    $settings = get_module_settings($module);
    page_title('Purchase Additional VPS HD Space');
    Severity: Minor
    Found in src/vps_hdspace.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $repeat_invoices is not named in camelCase.
    Open

    function vps_hdspace()
{
    $module = 'vps';
    $settings = get_module_settings($module);
    page_title('Purchase Additional VPS HD Space');
    Severity: Minor
    Found in src/vps_hdspace.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    The variable $repeat_invoice is not named in camelCase.
    Open

    function vps_hdspace()
{
    $module = 'vps';
    $settings = get_module_settings($module);
    page_title('Purchase Additional VPS HD Space');
    Severity: Minor
    Found in src/vps_hdspace.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

    Source

    Severity
    Category
    Status
    Source
    Language