Function createRequest
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
public function createRequest($url, $method, $arr = null, $headers = null)
{
$this->curr_url = $url;
$this->req = new HTTP_Request($url);
if (is_array($headers)) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Missing class import via use statement (line '58', column '26'). Open
$this->req = new HTTP_Request($url);
- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}
Source http://phpmd.org/rules/cleancode.html#MissingImport
The method sendRequest() contains an exit expression. Open
die();
- Read upRead up
- Exclude checks
ExitExpression
Since: 0.2
An exit-expression within regular code is untestable and therefore it should be avoided. Consider to move the exit-expression into some kind of startup script where an error/exception code is returned to the calling environment.
Example
class Foo {
public function bar($param) {
if ($param === 42) {
exit(23);
}
}
}
Source https://phpmd.org/rules/design.html#exitexpression
The property $root_url is not named in camelCase. Open
class RESTClient
{
private $root_url = '';
private $curr_url = '';
private $user_name = '';
- Read upRead up
- Exclude checks
CamelCasePropertyName
Since: 0.2
It is considered best practice to use the camelCase notation to name attributes.
Example
class ClassName {
protected $property_name;
}
Source
The parameter $user_name is not named in camelCase. Open
public function __construct($root_url = '', $user_name = '', $password = '')
{
$this->root_url = $this->curr_url = $root_url;
$this->user_name = $user_name;
$this->password = $password;
- Read upRead up
- Exclude checks
CamelCaseParameterName
Since: 0.2
It is considered best practice to use the camelCase notation to name parameters.
Example
class ClassName {
public function doSomething($user_name) {
}
}
Source
The property $user_name is not named in camelCase. Open
class RESTClient
{
private $root_url = '';
private $curr_url = '';
private $user_name = '';
- Read upRead up
- Exclude checks
CamelCasePropertyName
Since: 0.2
It is considered best practice to use the camelCase notation to name attributes.
Example
class ClassName {
protected $property_name;
}
Source
The parameter $root_url is not named in camelCase. Open
public function __construct($root_url = '', $user_name = '', $password = '')
{
$this->root_url = $this->curr_url = $root_url;
$this->user_name = $user_name;
$this->password = $password;
- Read upRead up
- Exclude checks
CamelCaseParameterName
Since: 0.2
It is considered best practice to use the camelCase notation to name parameters.
Example
class ClassName {
public function doSomething($user_name) {
}
}
Source
The property $curr_url is not named in camelCase. Open
class RESTClient
{
private $root_url = '';
private $curr_url = '';
private $user_name = '';
- Read upRead up
- Exclude checks
CamelCasePropertyName
Since: 0.2
It is considered best practice to use the camelCase notation to name attributes.
Example
class ClassName {
protected $property_name;
}
Source
The variable $root_url is not named in camelCase. Open
public function __construct($root_url = '', $user_name = '', $password = '')
{
$this->root_url = $this->curr_url = $root_url;
$this->user_name = $user_name;
$this->password = $password;
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $root_url is not named in camelCase. Open
public function __construct($root_url = '', $user_name = '', $password = '')
{
$this->root_url = $this->curr_url = $root_url;
$this->user_name = $user_name;
$this->password = $password;
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $user_name is not named in camelCase. Open
public function __construct($root_url = '', $user_name = '', $password = '')
{
$this->root_url = $this->curr_url = $root_url;
$this->user_name = $user_name;
$this->password = $password;
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}
Source
The variable $root_url is not named in camelCase. Open
public function __construct($root_url = '', $user_name = '', $password = '')
{
$this->root_url = $this->curr_url = $root_url;
$this->user_name = $user_name;
$this->password = $password;
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}