detain/myadmin-maxmind-plugin

View on GitHub
src/maxmind.inc.php

Summary

Maintainability
F
5 days
Test Coverage

Function update_maxmind_noaccount has a Cognitive Complexity of 82 (exceeds 5 allowed). Consider refactoring.
Open

function update_maxmind_noaccount($data)
{
    require_once __DIR__.'/../../../minfraud/http/src/CreditCardFraudDetection.php';
    //require_once ('include/accounts/maxmind/CreditCardFraudDetection.php');
    //myadmin_log('maxmind', 'debug', "update_maxmind_noaccount Called", __LINE__, __FILE__);
Severity: Minor
Found in src/maxmind.inc.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function update_maxmind has a Cognitive Complexity of 67 (exceeds 5 allowed). Consider refactoring.
Open

function update_maxmind($custid, $ip = false, $ccIdx = false)
{
    $custid = (int)$custid;
    $good = true;
    $new_data = [];
Severity: Minor
Found in src/maxmind.inc.php - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method update_maxmind has 173 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function update_maxmind($custid, $ip = false, $ccIdx = false)
{
    $custid = (int)$custid;
    $good = true;
    $new_data = [];
Severity: Major
Found in src/maxmind.inc.php - About 6 hrs to fix

    File maxmind.inc.php has 386 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    /**
     * MaxMind Fraud Stuff
     *
     * API Downloaded @ http://www.maxmind.com/download/ccfd/
    Severity: Minor
    Found in src/maxmind.inc.php - About 5 hrs to fix

      Method update_maxmind_noaccount has 113 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function update_maxmind_noaccount($data)
      {
          require_once __DIR__.'/../../../minfraud/http/src/CreditCardFraudDetection.php';
          //require_once ('include/accounts/maxmind/CreditCardFraudDetection.php');
          //myadmin_log('maxmind', 'debug', "update_maxmind_noaccount Called", __LINE__, __FILE__);
      Severity: Major
      Found in src/maxmind.inc.php - About 4 hrs to fix

        Method get_maxmind_field_descriptions has 84 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function get_maxmind_field_descriptions()
        {
            $fields = [
                'distance' => 'Distance from IP address location to billing location in kilometers (large distance = higher risk).',
                'countryMatch' => 'Whether country of IP address matches billing address country (mismatch = higher risk).',
        Severity: Major
        Found in src/maxmind.inc.php - About 3 hrs to fix

          Consider simplifying this complex logical expression.
          Open

              if ((MAXMIND_CARDER_LOCK == true && isset($response['carderEmail']) && $response['carderEmail'] == 'Yes') || (isset($response['score']) && $response['score'] >= MAXMIND_SCORE_LOCK) || $response['riskScore'] >= MAXMIND_RISKSCORE_LOCK) {
                  $db->query("select * from invoices where invoices_type=1 and invoices_paid=1 and invoices_custid={$custid} and invoices_date <= date_sub(now(), INTERVAL 1 DAY) limit 1", __LINE__, __FILE__);
                  if ($db->num_rows() == 0) {
                      myadmin_log('maxmind', 'warning', "update_maxmind({$custid}, {$ip}) Carder Email Or High Score From Customer {$custid} (".(isset($response['score']) ? 'Score: '.$response['score'] : '')." RiskScore {$response['riskScore']}), Disabling Account", __LINE__, __FILE__);
                      function_requirements('disable_account');
          Severity: Major
          Found in src/maxmind.inc.php - About 40 mins to fix

            Avoid using undefined variables such as '$request' which will lead to PHP notices.
            Open

                        $request['city'] = $data['city'];
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$custid' which will lead to PHP notices.
            Open

                    myadmin_log('maxmind', 'debug', "update_maxmind({$custid}, {$ip}) Calling With Arguments: " . json_encode($request), __LINE__, __FILE__);
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$new_data' which will lead to PHP notices.
            Open

                        myadmin_log('maxmind', 'debug', $new_data['maxmind'], __LINE__, __FILE__);
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$ip' which will lead to PHP notices.
            Open

                            myadmin_log('maxmind', 'warning', "update_maxmind({$custid}, {$ip}) BLANK Maxmind Score and BLANK MaxMind Risk % Score, Disabling CC and Setting Payment Method To PayPal", __LINE__, __FILE__);
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$ip' which will lead to PHP notices.
            Open

                    myadmin_log('maxmind', 'debug', "update_maxmind({$custid}, {$ip}) Calling With Arguments: " . json_encode($request), __LINE__, __FILE__);
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$ip' which will lead to PHP notices.
            Open

                    myadmin_log('maxmind', 'notice', "update_maxmind({$custid}, {$ip}) Blank Required Fields - Disabling CC", __LINE__, __FILE__);
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$request' which will lead to PHP notices.
            Open

                    $request['emailMD5'] = md5($data['lid']); // CreditCardFraudDetection.php will take
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$request' which will lead to PHP notices.
            Open

                    $request['requested_type'] = 'premium'; // Which level (free, city, premium) of CCFD to use
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$custid' which will lead to PHP notices.
            Open

                            myadmin_log('maxmind', 'warning', "update_maxmind({$custid}, {$ip}) ".(isset($response['score']) ? "{$response['score']} >= " . MAXMIND_SCORE_DISABLE_CC : ''). " or  {$response['riskScore']} >= " . MAXMIND_RISKSCORE_DISABLE_CC.' Fraud Score, Disabling CC and Setting Payment Method To PayPal', __LINE__, __FILE__);
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$request' which will lead to PHP notices.
            Open

                    $request['license_key'] = MAXMIND_LICENSE_KEY;
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$request' which will lead to PHP notices.
            Open

                        $request['bin'] = mb_substr($GLOBALS['tf']->decrypt($data['cc']), 0, 6);
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$request' which will lead to PHP notices.
            Open

                    $request['domain'] = mb_substr($data['lid'], mb_strpos($data['lid'], '@') + 1);
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$request' which will lead to PHP notices.
            Open

                    myadmin_log('maxmind', 'debug', "update_maxmind({$custid}, {$ip}) Calling With Arguments: " . json_encode($request), __LINE__, __FILE__);
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$request' which will lead to PHP notices.
            Open

                        $request['country'] = $data['country'];
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$request' which will lead to PHP notices.
            Open

                        $request['postal'] = $data['zip'];
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$request' which will lead to PHP notices.
            Open

                    $request['usernameMD5'] = md5($data['lid']);
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$request' which will lead to PHP notices.
            Open

                    $ccfs->input($request);
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$custid' which will lead to PHP notices.
            Open

                    myadmin_log('maxmind', 'notice', "update_maxmind({$custid}, {$ip}) Blank Required Fields - Disabling CC", __LINE__, __FILE__);
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$request' which will lead to PHP notices.
            Open

                        $request['region'] = $data['state'];
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$ip' which will lead to PHP notices.
            Open

                        $request['forwardedIP'] = $ip;
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$request' which will lead to PHP notices.
            Open

                    $request['custPhone'] = $data['phone']; // Area-code and local prefix of customer phone number
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$request' which will lead to PHP notices.
            Open

                    $request['i'] = \MyAdmin\Session::get_client_ip();
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$ip' which will lead to PHP notices.
            Open

                    if ($ip !== false) {
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$ip' which will lead to PHP notices.
            Open

                            myadmin_log('maxmind', 'warning', "update_maxmind({$custid}, {$ip}) ".(isset($response['score']) ? "{$response['score']} >= " . MAXMIND_SCORE_DISABLE_CC : ''). " or  {$response['riskScore']} >= " . MAXMIND_RISKSCORE_DISABLE_CC.' Fraud Score, Disabling CC and Setting Payment Method To PayPal', __LINE__, __FILE__);
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$custid' which will lead to PHP notices.
            Open

                            myadmin_log('maxmind', 'warning', "update_maxmind({$custid}, {$ip}) BLANK Maxmind Score and BLANK MaxMind Risk % Score, Disabling CC and Setting Payment Method To PayPal", __LINE__, __FILE__);
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Avoid using undefined variables such as '$request' which will lead to PHP notices.
            Open

                        $request['forwardedIP'] = $ip;
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            UndefinedVariable

            Since: 2.8.0

            Detects when a variable is used that has not been defined before.

            Example

            class Foo
            {
                private function bar()
                {
                    // $message is undefined
                    echo $message;
                }
            }

            Source https://phpmd.org/rules/cleancode.html#undefinedvariable

            Remove error control operator '@' on line 268.
            Open

            function update_maxmind($custid, $ip = false, $ccIdx = false)
            {
                $custid = (int)$custid;
                $good = true;
                $new_data = [];
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            ErrorControlOperator

            Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

            Example

            function foo($filePath) {
                $file = @fopen($filPath); // hides exceptions
                $key = @$array[$notExistingKey]; // assigns null to $key
            }

            Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

            Missing class import via use statement (line '275', column '19').
            Open

                $smarty = new TFSmarty();
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            MissingImport

            Since: 2.7.0

            Importing all external classes in a file through use statements makes them clearly visible.

            Example

            function make() {
                return new \stdClass();
            }

            Source http://phpmd.org/rules/cleancode.html#MissingImport

            Missing class import via use statement (line '315', column '14').
            Open

                    (new \MyAdmin\Mail())->adminMail($subject, $email, false, 'admin/fraud.tpl');
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            MissingImport

            Since: 2.7.0

            Importing all external classes in a file through use statements makes them clearly visible.

            Example

            function make() {
                return new \stdClass();
            }

            Source http://phpmd.org/rules/cleancode.html#MissingImport

            Remove error control operator '@' on line 273.
            Open

            function update_maxmind($custid, $ip = false, $ccIdx = false)
            {
                $custid = (int)$custid;
                $good = true;
                $new_data = [];
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            ErrorControlOperator

            Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

            Example

            function foo($filePath) {
                $file = @fopen($filPath); // hides exceptions
                $key = @$array[$notExistingKey]; // assigns null to $key
            }

            Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

            Missing class import via use statement (line '217', column '17').
            Open

                $ccfs = new CreditCardFraudDetection();
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            MissingImport

            Since: 2.7.0

            Importing all external classes in a file through use statements makes them clearly visible.

            Example

            function make() {
                return new \stdClass();
            }

            Source http://phpmd.org/rules/cleancode.html#MissingImport

            Missing class import via use statement (line '319', column '14').
            Open

                    (new \MyAdmin\Mail())->adminMail($subject, $email, false, 'admin/fraud.tpl');
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            MissingImport

            Since: 2.7.0

            Importing all external classes in a file through use statements makes them clearly visible.

            Example

            function make() {
                return new \stdClass();
            }

            Source http://phpmd.org/rules/cleancode.html#MissingImport

            Missing class import via use statement (line '325', column '14').
            Open

                    (new \MyAdmin\Mail())->adminMail($subject, $subject, false, 'admin/maxmind_queries.tpl');
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            MissingImport

            Since: 2.7.0

            Importing all external classes in a file through use statements makes them clearly visible.

            Example

            function make() {
                return new \stdClass();
            }

            Source http://phpmd.org/rules/cleancode.html#MissingImport

            Missing class import via use statement (line '358', column '21').
            Open

                    $ccfs = new CreditCardFraudDetection();
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            MissingImport

            Since: 2.7.0

            Importing all external classes in a file through use statements makes them clearly visible.

            Example

            function make() {
                return new \stdClass();
            }

            Source http://phpmd.org/rules/cleancode.html#MissingImport

            Avoid unused local variables such as '$new_data'.
            Open

                        myadmin_log('maxmind', 'debug', $new_data['maxmind'], __LINE__, __FILE__);
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            UnusedLocalVariable

            Since: 0.2

            Detects when a local variable is declared and/or assigned, but not used.

            Example

            class Foo {
                public function doSomething()
                {
                    $i = 5; // Unused
                }
            }

            Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

            The parameter $encoded_maxmind is not named in camelCase.
            Open

            function maxmind_decode($encoded_maxmind)
            {
                return myadmin_unstringify($encoded_maxmind);
            }
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            CamelCaseParameterName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name parameters.

            Example

            class ClassName {
                public function doSomething($user_name) {
                }
            }

            Source

            The variable $distance_penalty is not named in camelCase.
            Open

            function update_maxmind($custid, $ip = false, $ccIdx = false)
            {
                $custid = (int)$custid;
                $good = true;
                $new_data = [];
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $md5_passwd is not named in camelCase.
            Open

            function update_maxmind($custid, $ip = false, $ccIdx = false)
            {
                $custid = (int)$custid;
                $good = true;
                $new_data = [];
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $female_names is not named in camelCase.
            Open

            function update_maxmind($custid, $ip = false, $ccIdx = false)
            {
                $custid = (int)$custid;
                $good = true;
                $new_data = [];
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $first_name is not named in camelCase.
            Open

            function update_maxmind($custid, $ip = false, $ccIdx = false)
            {
                $custid = (int)$custid;
                $good = true;
                $new_data = [];
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $md5_passwd is not named in camelCase.
            Open

            function update_maxmind($custid, $ip = false, $ccIdx = false)
            {
                $custid = (int)$custid;
                $good = true;
                $new_data = [];
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $new_data is not named in camelCase.
            Open

            function update_maxmind($custid, $ip = false, $ccIdx = false)
            {
                $custid = (int)$custid;
                $good = true;
                $new_data = [];
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $new_data is not named in camelCase.
            Open

            function update_maxmind($custid, $ip = false, $ccIdx = false)
            {
                $custid = (int)$custid;
                $good = true;
                $new_data = [];
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $new_data is not named in camelCase.
            Open

            function update_maxmind($custid, $ip = false, $ccIdx = false)
            {
                $custid = (int)$custid;
                $good = true;
                $new_data = [];
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $new_data is not named in camelCase.
            Open

            function update_maxmind($custid, $ip = false, $ccIdx = false)
            {
                $custid = (int)$custid;
                $good = true;
                $new_data = [];
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $distance_penalty is not named in camelCase.
            Open

            function update_maxmind_noaccount($data)
            {
                require_once __DIR__.'/../../../minfraud/http/src/CreditCardFraudDetection.php';
                //require_once ('include/accounts/maxmind/CreditCardFraudDetection.php');
                //myadmin_log('maxmind', 'debug', "update_maxmind_noaccount Called", __LINE__, __FILE__);
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $new_data is not named in camelCase.
            Open

            function update_maxmind($custid, $ip = false, $ccIdx = false)
            {
                $custid = (int)$custid;
                $good = true;
                $new_data = [];
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $new_data is not named in camelCase.
            Open

            function update_maxmind($custid, $ip = false, $ccIdx = false)
            {
                $custid = (int)$custid;
                $good = true;
                $new_data = [];
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $new_data is not named in camelCase.
            Open

            function update_maxmind_noaccount($data)
            {
                require_once __DIR__.'/../../../minfraud/http/src/CreditCardFraudDetection.php';
                //require_once ('include/accounts/maxmind/CreditCardFraudDetection.php');
                //myadmin_log('maxmind', 'debug', "update_maxmind_noaccount Called", __LINE__, __FILE__);
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $new_data is not named in camelCase.
            Open

            function update_maxmind($custid, $ip = false, $ccIdx = false)
            {
                $custid = (int)$custid;
                $good = true;
                $new_data = [];
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $distance_penalty is not named in camelCase.
            Open

            function update_maxmind_noaccount($data)
            {
                require_once __DIR__.'/../../../minfraud/http/src/CreditCardFraudDetection.php';
                //require_once ('include/accounts/maxmind/CreditCardFraudDetection.php');
                //myadmin_log('maxmind', 'debug', "update_maxmind_noaccount Called", __LINE__, __FILE__);
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $new_data is not named in camelCase.
            Open

            function update_maxmind($custid, $ip = false, $ccIdx = false)
            {
                $custid = (int)$custid;
                $good = true;
                $new_data = [];
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $female_names is not named in camelCase.
            Open

            function update_maxmind_noaccount($data)
            {
                require_once __DIR__.'/../../../minfraud/http/src/CreditCardFraudDetection.php';
                //require_once ('include/accounts/maxmind/CreditCardFraudDetection.php');
                //myadmin_log('maxmind', 'debug', "update_maxmind_noaccount Called", __LINE__, __FILE__);
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $first_name is not named in camelCase.
            Open

            function update_maxmind($custid, $ip = false, $ccIdx = false)
            {
                $custid = (int)$custid;
                $good = true;
                $new_data = [];
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $distance_penalty is not named in camelCase.
            Open

            function update_maxmind($custid, $ip = false, $ccIdx = false)
            {
                $custid = (int)$custid;
                $good = true;
                $new_data = [];
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $distance_penalty is not named in camelCase.
            Open

            function update_maxmind($custid, $ip = false, $ccIdx = false)
            {
                $custid = (int)$custid;
                $good = true;
                $new_data = [];
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $distance_penalty is not named in camelCase.
            Open

            function update_maxmind($custid, $ip = false, $ccIdx = false)
            {
                $custid = (int)$custid;
                $good = true;
                $new_data = [];
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $first_name is not named in camelCase.
            Open

            function update_maxmind_noaccount($data)
            {
                require_once __DIR__.'/../../../minfraud/http/src/CreditCardFraudDetection.php';
                //require_once ('include/accounts/maxmind/CreditCardFraudDetection.php');
                //myadmin_log('maxmind', 'debug', "update_maxmind_noaccount Called", __LINE__, __FILE__);
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $new_data is not named in camelCase.
            Open

            function update_maxmind($custid, $ip = false, $ccIdx = false)
            {
                $custid = (int)$custid;
                $good = true;
                $new_data = [];
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $new_data is not named in camelCase.
            Open

            function update_maxmind($custid, $ip = false, $ccIdx = false)
            {
                $custid = (int)$custid;
                $good = true;
                $new_data = [];
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $female_names is not named in camelCase.
            Open

            function update_maxmind_noaccount($data)
            {
                require_once __DIR__.'/../../../minfraud/http/src/CreditCardFraudDetection.php';
                //require_once ('include/accounts/maxmind/CreditCardFraudDetection.php');
                //myadmin_log('maxmind', 'debug', "update_maxmind_noaccount Called", __LINE__, __FILE__);
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $first_name is not named in camelCase.
            Open

            function update_maxmind_noaccount($data)
            {
                require_once __DIR__.'/../../../minfraud/http/src/CreditCardFraudDetection.php';
                //require_once ('include/accounts/maxmind/CreditCardFraudDetection.php');
                //myadmin_log('maxmind', 'debug', "update_maxmind_noaccount Called", __LINE__, __FILE__);
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $female_names is not named in camelCase.
            Open

            function update_maxmind($custid, $ip = false, $ccIdx = false)
            {
                $custid = (int)$custid;
                $good = true;
                $new_data = [];
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $distance_penalty is not named in camelCase.
            Open

            function update_maxmind($custid, $ip = false, $ccIdx = false)
            {
                $custid = (int)$custid;
                $good = true;
                $new_data = [];
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $distance_penalty is not named in camelCase.
            Open

            function update_maxmind_noaccount($data)
            {
                require_once __DIR__.'/../../../minfraud/http/src/CreditCardFraudDetection.php';
                //require_once ('include/accounts/maxmind/CreditCardFraudDetection.php');
                //myadmin_log('maxmind', 'debug', "update_maxmind_noaccount Called", __LINE__, __FILE__);
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $distance_penalty is not named in camelCase.
            Open

            function update_maxmind($custid, $ip = false, $ccIdx = false)
            {
                $custid = (int)$custid;
                $good = true;
                $new_data = [];
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $new_data is not named in camelCase.
            Open

            function update_maxmind($custid, $ip = false, $ccIdx = false)
            {
                $custid = (int)$custid;
                $good = true;
                $new_data = [];
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $encoded_maxmind is not named in camelCase.
            Open

            function maxmind_decode($encoded_maxmind)
            {
                return myadmin_unstringify($encoded_maxmind);
            }
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $new_data is not named in camelCase.
            Open

            function update_maxmind($custid, $ip = false, $ccIdx = false)
            {
                $custid = (int)$custid;
                $good = true;
                $new_data = [];
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            The variable $new_data is not named in camelCase.
            Open

            function update_maxmind($custid, $ip = false, $ccIdx = false)
            {
                $custid = (int)$custid;
                $good = true;
                $new_data = [];
            Severity: Minor
            Found in src/maxmind.inc.php by phpmd

            CamelCaseVariableName

            Since: 0.2

            It is considered best practice to use the camelCase notation to name variables.

            Example

            class ClassName {
                public function doSomething() {
                    $data_module = new DataModule();
                }
            }

            Source

            There are no issues that match your filters.

            Category
            Status