detain/myadmin-maxmind-plugin

View on GitHub
src/maxmind_compare.php

Summary

Maintainability
A
3 hrs
Test Coverage

Method maxmind_compare has 55 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function maxmind_compare()
    {
        function_requirements('has_acl');
        if ($GLOBALS['tf']->ima != 'admin' || !has_acl('view_customer')) {
            dialog('Not admin', 'Not Admin or you lack the permissions to view this page.');
Severity: Major
Found in src/maxmind_compare.php - About 2 hrs to fix

    Function maxmind_compare has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        function maxmind_compare()
        {
            function_requirements('has_acl');
            if ($GLOBALS['tf']->ima != 'admin' || !has_acl('view_customer')) {
                dialog('Not admin', 'Not Admin or you lack the permissions to view this page.');
    Severity: Minor
    Found in src/maxmind_compare.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid using undefined variables such as '$rows' which will lead to PHP notices.
    Open

            $smarty->assign('table_rows', $rows);
    Severity: Minor
    Found in src/maxmind_compare.php by phpmd

    UndefinedVariable

    Since: 2.8.0

    Detects when a variable is used that has not been defined before.

    Example

    class Foo
    {
        private function bar()
        {
            // $message is undefined
            echo $message;
        }
    }

    Source https://phpmd.org/rules/cleancode.html#undefinedvariable

    Avoid using undefined variables such as '$rows' which will lead to PHP notices.
    Open

                $rows[] = $db->Record;
    Severity: Minor
    Found in src/maxmind_compare.php by phpmd

    UndefinedVariable

    Since: 2.8.0

    Detects when a variable is used that has not been defined before.

    Example

    class Foo
    {
        private function bar()
        {
            // $message is undefined
            echo $message;
        }
    }

    Source https://phpmd.org/rules/cleancode.html#undefinedvariable

    Remove error control operator '@' on line 25.
    Open

        function maxmind_compare()
        {
            function_requirements('has_acl');
            if ($GLOBALS['tf']->ima != 'admin' || !has_acl('view_customer')) {
                dialog('Not admin', 'Not Admin or you lack the permissions to view this page.');
    Severity: Minor
    Found in src/maxmind_compare.php by phpmd

    ErrorControlOperator

    Error suppression should be avoided if possible as it doesn't just suppress the error, that you are trying to stop, but will also suppress errors that you didn't predict would ever occur. Consider changing error_reporting() level and/or setting up your own error handler.

    Example

    function foo($filePath) {
        $file = @fopen($filPath); // hides exceptions
        $key = @$array[$notExistingKey]; // assigns null to $key
    }

    Source http://phpmd.org/rules/cleancode.html#errorcontroloperator

    Missing class import via use statement (line '47', column '23').
    Open

            $smarty = new TFSmarty();
    Severity: Minor
    Found in src/maxmind_compare.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    There are no issues that match your filters.

    Category
    Status