Sign upLogin

detain/myadmin-plesk-webhosting

View on GitHub
Star
src/Plugin.php

Summary

Maintainability
F
4 days
Test Coverage

Function getActivate has a Cognitive Complexity of 109 (exceeds 5 allowed). Consider refactoring.
Open

    public static function getActivate(GenericEvent $event)
    {
        if ($event['category'] == get_service_define('WEB_PLESK')) {
            $serviceClass = $event->getSubject();
            myadmin_log(self::$module, 'info', 'Plesk Activation', __LINE__, __FILE__, self::$module, $serviceClass->getId());
Severity: Minor
Found in src/Plugin.php - About 2 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method getActivate has 220 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function getActivate(GenericEvent $event)
    {
        if ($event['category'] == get_service_define('WEB_PLESK')) {
            $serviceClass = $event->getSubject();
            myadmin_log(self::$module, 'info', 'Plesk Activation', __LINE__, __FILE__, self::$module, $serviceClass->getId());
Severity: Major
Found in src/Plugin.php - About 1 day to fix

    File Plugin.php has 362 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php

namespace Detain\MyAdminPlesk;

use Detain\MyAdminPlesk\ApiRequestException;
    Severity: Minor
    Found in src/Plugin.php - About 4 hrs to fix

      Method getTerminate has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public static function getTerminate(GenericEvent $event)
    {
        if ($event['category'] == get_service_define('WEB_PLESK')) {
            $event->stopPropagation();
            $serviceClass = $event->getSubject();
      Severity: Minor
      Found in src/Plugin.php - About 1 hr to fix

        Function getTerminate has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            public static function getTerminate(GenericEvent $event)
    {
        if ($event['category'] == get_service_define('WEB_PLESK')) {
            $event->stopPropagation();
            $serviceClass = $event->getSubject();
        Severity: Minor
        Found in src/Plugin.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

                        return;
        Severity: Major
        Found in src/Plugin.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                          return;
          Severity: Major
          Found in src/Plugin.php - About 30 mins to fix

            Missing class import via use statement (line '81', column '27').
            Open

                            throw new \Exception('Failed getting server information.'.(isset($result['errtext']) ? ' Error message was: '.$result['errtext'].'.' : ''));
            Severity: Minor
            Found in src/Plugin.php by phpmd

            MissingImport

            Since: 2.7.0

            Importing all external classes in a file through use statements makes them clearly visible.

            Example

            function make() {
    return new \stdClass();
}

            Source http://phpmd.org/rules/cleancode.html#MissingImport

            Avoid unused local variables such as '$extra'.
            Open

                        $extra = run_event('parse_service_extra', $serviceClass->getExtra(), self::$module);
            Severity: Minor
            Found in src/Plugin.php by phpmd

            UnusedLocalVariable

            Since: 0.2

            Detects when a local variable is declared and/or assigned, but not used.

            Example

            class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

            Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

            Avoid unused local variables such as '$usernameUpdated'.
            Open

                                    $usernameUpdated = true;
            Severity: Minor
            Found in src/Plugin.php by phpmd

            UnusedLocalVariable

            Since: 0.2

            Detects when a local variable is declared and/or assigned, but not used.

            Example

            class Foo {
    public function doSomething()
    {
        $i = 5; // Unused
    }
}

            Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

            There are no issues that match your filters.

            Category
            Status