detain/myadmin-plugin-installer

Method add_route_requirement has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

    public function add_route_requirement($type, $function, $source = '', $path = false, $methods = false)

The property $admin_routes is not named in camelCase.

Open

class Loader
{
    protected $requirements;
    protected $routes;
    protected $admin_routes;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    protected $property_name;
}

The property $public_routes is not named in camelCase.

Open

class Loader
{
    protected $requirements;
    protected $routes;
    protected $admin_routes;

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    protected $property_name;
}

The method add_api_page_requirement is not named in camelCase.

Open

    public function add_api_page_requirement($function, $source, $methods = false)
    {
        $this->add_route_requirement('client_api', $function, $source, '/apiv2/'.$function, $methods);
        $this->add_route_requirement('client_api', $function, $source, '/admin/apiv2/'.$function, $methods);
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function get_name() {
    }
}

The method add_admin_page_requirement is not named in camelCase.

Open

    public function add_admin_page_requirement($function, $source, $methods = false)
    {
        $this->add_route_requirement('admin', $function, $source, '/admin/'.$function, $methods);
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function get_name() {
    }
}

The method add_route_requirement is not named in camelCase.

Open

    public function add_route_requirement($type, $function, $source = '', $path = false, $methods = false)
    {
        if ($path === false) {
            $path = '/'.$function;
        }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function get_name() {
    }
}

The method add_page_requirement is not named in camelCase.

Open

    public function add_page_requirement($function, $source, $methods = false)
    {
        $this->add_route_requirement('client', $function, $source, '/'.$function, $methods);
        $this->add_route_requirement('client', $function, $source, '/admin/'.$function, $methods);
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function get_name() {
    }
}

The method add_public_requirement is not named in camelCase.

Open

    public function add_public_requirement($function, $source, $methods = false)
    {
        $this->add_route_requirement('public', $function, $source, '/'.$function, $methods);
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function get_name() {
    }
}

The method add_public_file is not named in camelCase.

Open

    public function add_public_file($function, $source, $methods = false)
    {
        $this->add_route_requirement('public_file', $function, $source, '', '/'.$function, $methods);
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function get_name() {
    }
}

The method get_setting is not named in camelCase.

Open

    public function get_setting($setting)
    {
        return constant($setting);
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function get_name() {
    }
}

The method add_root_page_requirement is not named in camelCase.

Open

    public function add_root_page_requirement($function, $source, $methods = false)
    {
        $this->add_route_requirement('client', $function, $source, '/'.$function, $methods);
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function get_name() {
    }
}

The method add_ajax_page_requirement is not named in camelCase.

Open

    public function add_ajax_page_requirement($function, $source, $methods = false)
    {
        $this->add_route_requirement('client_ajax', $function, $source, '/ajax/'.$function, $methods);
        $this->add_route_requirement('client_ajax', $function, $source, '/admin/ajax/'.$function, $methods);
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function get_name() {
    }
}

The method add_apmin_api_page_requirement is not named in camelCase.

Open

    public function add_apmin_api_page_requirement($function, $source, $methods = false)
    {
        $this->add_route_requirement('admin_api', $function, $source, '/admin/ajax/'.$function, $methods);
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function get_name() {
    }
}

The method add_requirement is not named in camelCase.

Open

    public function add_requirement($function, $source, $methods = false)
    {
        if ($source != '') {
            $this->requirements[$function] = $source;
        }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function get_name() {
    }
}

The method get_requirements is not named in camelCase.

Open

    public function get_requirements()
    {
        return $this->requirements;
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function get_name() {
    }
}

The method get_routes is not named in camelCase.

Open

    public function get_routes()
    {
        $routes = $this->routes;
        uksort($routes, function ($a, $b) {
            if (strlen($a) == strlen($b)) {

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class ClassName {
    public function get_name() {
    }
}