detain/myadmin-quickservers-module

View on GitHub
src/Plugin.php

Summary

Maintainability
A
2 hrs
Test Coverage

Method loadProcessing has 54 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function loadProcessing(GenericEvent $event)
    {
        /**
         * @var \ServiceHandler $service
         */
Severity: Major
Found in src/Plugin.php - About 2 hrs to fix

    Missing class import via use statement (line '161', column '27').
    Open

                $smarty = new \TFSmarty();
    Severity: Minor
    Found in src/Plugin.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '105', column '22').
    Open

                    (new \MyAdmin\Mail())->adminMail($subject, $email, false, 'admin/qs_reactivated.tpl');
    Severity: Minor
    Found in src/Plugin.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '101', column '31').
    Open

                    $smarty = new \TFSmarty();
    Severity: Minor
    Found in src/Plugin.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Avoid unused local variables such as '$server_info'.
    Open

            $server_info = $serviceInfo['server_info'];
    Severity: Minor
    Found in src/Plugin.php by phpmd

    UnusedLocalVariable

    Since: 0.2

    Detects when a local variable is declared and/or assigned, but not used.

    Example

    class Foo {
        public function doSomething()
        {
            $i = 5; // Unused
        }
    }

    Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

    Avoid unused local variables such as '$class'.
    Open

                    $class = '\\MyAdmin\\Orm\\'.get_orm_class_from_table($settings['TABLE']);
    Severity: Minor
    Found in src/Plugin.php by phpmd

    UnusedLocalVariable

    Since: 0.2

    Detects when a local variable is declared and/or assigned, but not used.

    Example

    class Foo {
        public function doSomething()
        {
            $i = 5; // Unused
        }
    }

    Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

    The variable $server_info is not named in camelCase.
    Open

        public static function getQueue(GenericEvent $event)
        {
            //if (in_array($event['type'], [get_service_define('KVM_LINUX'), get_service_define('KVM_WINDOWS'), get_service_define('CLOUD_KVM_LINUX'), get_service_define('CLOUD_KVM_WINDOWS')])) {
            $settings = get_module_settings(self::$module);
            $serviceInfo = $event->getSubject();
    Severity: Minor
    Found in src/Plugin.php by phpmd

    CamelCaseVariableName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name variables.

    Example

    class ClassName {
        public function doSomething() {
            $data_module = new DataModule();
        }
    }

    Source

    There are no issues that match your filters.

    Category
    Status