detain/myadmin-servers-module

View on GitHub
src/Plugin.php

Summary

Maintainability
A
1 hr
Test Coverage

Method loadProcessing has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function loadProcessing(GenericEvent $event)
    {
        /**
         * @var \ServiceHandler $service
         */
Severity: Minor
Found in src/Plugin.php - About 1 hr to fix

    Missing class import via use statement (line '110', column '31').
    Open

                    $smarty = new \TFSmarty();
    Severity: Minor
    Found in src/Plugin.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '114', column '22').
    Open

                    (new \MyAdmin\Mail())->adminMail($subject, $email, false, 'admin/server_reactivated.tpl');
    Severity: Minor
    Found in src/Plugin.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Avoid unused local variables such as '$serviceTypes'.
    Open

            $serviceTypes = run_event('get_service_types', false, self::$module);
    Severity: Minor
    Found in src/Plugin.php by phpmd

    UnusedLocalVariable

    Since: 0.2

    Detects when a local variable is declared and/or assigned, but not used.

    Example

    class Foo {
        public function doSomething()
        {
            $i = 5; // Unused
        }
    }

    Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable

    There are no issues that match your filters.

    Category
    Status