Sign upLogin

detain/myadmin-softaculous-licensing

View on GitHub
Star

Showing 108 of 108 total issues

Avoid using undefined variables such as '$return' which will lead to PHP notices.
Open

                $return['status'] = 'ok';
Severity: Minor
Found in src/Plugin.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using undefined variables such as '$return' which will lead to PHP notices.
Open

                $return['status'] = 'error';
Severity: Minor
Found in src/Plugin.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using undefined variables such as '$response' which will lead to PHP notices.
Open

        myadmin_log('licenses', 'info', '<pre>'.json_encode($response).'</pre>', __LINE__, __FILE__);
Severity: Minor
Found in src/SoftaculousNOC.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using undefined variables such as '$return' which will lead to PHP notices.
Open

                $return['status_text'] = 'The IP Address has been changed.';
Severity: Minor
Found in src/Plugin.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

Avoid using undefined variables such as '$ipAddress' which will lead to PHP notices.
Open

        $licenses =  $noc->webuzo_licenses('', $ipAddress);
Severity: Minor
Found in src/webuzo_list.php by phpmd

UndefinedVariable

Since: 2.8.0

Detects when a variable is used that has not been defined before.

Example

class Foo
{
    private function bar()
    {
        // $message is undefined
        echo $message;
    }
}

Source https://phpmd.org/rules/cleancode.html#undefinedvariable

The parameter $buy_sitepad is not named in camelCase.
Open

    public function buy($ip, $toadd, $servertype, $authemail, $autorenew, $buy_sitepad = 0)
    {
        $this->params['ca'] = 'softaculous_buy';
        $this->params['purchase'] = 1;
        $this->params['ips'] = $ip;
Severity: Minor
Found in src/SoftaculousNOC.php by phpmd

CamelCaseParameterName

Since: 0.2

It is considered best practice to use the camelCase notation to name parameters.

Example

class ClassName {
    public function doSomething($user_name) {
    }
}

Source

The property $raw_response is not named in camelCase.
Open

class SoftaculousNOC
{
    private $nocname = 'username';
    private $nocpass = 'password';
    public $softaculous = 'https://www.softaculous.com/noc';
Severity: Minor
Found in src/SoftaculousNOC.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

Function activate_softaculous has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

function activate_softaculous($ipAddress, $field, $email)
{
    myadmin_log('softaculous', 'info', "activating softaculous({$ipAddress}, {$field}, {$email})", __LINE__, __FILE__);
    try {
        $noc = new \Detain\MyAdminSoftaculous\SoftaculousNOC(SOFTACULOUS_USERNAME, SOFTACULOUS_PASSWORD);
Severity: Minor
Found in src/activate_softaculous.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method buy has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function buy($ip, $toadd, $servertype, $authemail, $autorenew, $buy_sitepad = 0)
Severity: Minor
Found in src/SoftaculousNOC.php - About 45 mins to fix

    Method virt_licenses has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public function virt_licenses($key = '', $ip = '', $expiry = '', $start = 0, $len = 1000000, $email = '')
    Severity: Minor
    Found in src/SoftaculousNOC.php - About 45 mins to fix

      Method licenses has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public function licenses($key = '', $ip = '', $expiry = '', $start = 0, $len = 1000000, $email = '')
      Severity: Minor
      Found in src/SoftaculousNOC.php - About 45 mins to fix

        Method sitemush_licenses has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public function sitemush_licenses($key = '', $ip = '', $expiry = '', $start = 0, $len = 1000000, $email = '')
        Severity: Minor
        Found in src/SoftaculousNOC.php - About 45 mins to fix

          Method webuzo_licenses has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public function webuzo_licenses($key = '', $ip = '', $expiry = '', $start = 0, $len = 1000000, $email = '')
          Severity: Minor
          Found in src/SoftaculousNOC.php - About 45 mins to fix

            Method webuzo_buy has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                public function webuzo_buy($ip, $toadd, $servertype, $authemail, $autorenew)
            Severity: Minor
            Found in src/SoftaculousNOC.php - About 35 mins to fix

              Missing class import via use statement (line '13', column '22').
              Open

                      $table = new \TFTable();
              Severity: Minor
              Found in src/webuzo_list.php by phpmd

              MissingImport

              Since: 2.7.0

              Importing all external classes in a file through use statements makes them clearly visible.

              Example

              function make() {
    return new \stdClass();
}

              Source http://phpmd.org/rules/cleancode.html#MissingImport

              Missing class import via use statement (line '145', column '24').
              Open

                          $noc = new \Detain\MyAdminSoftaculous\SoftaculousNOC(SOFTACULOUS_USERNAME, SOFTACULOUS_PASSWORD);
              Severity: Minor
              Found in src/Plugin.php by phpmd

              MissingImport

              Since: 2.7.0

              Importing all external classes in a file through use statements makes them clearly visible.

              Example

              function make() {
    return new \stdClass();
}

              Source http://phpmd.org/rules/cleancode.html#MissingImport

              Missing class import via use statement (line '22', column '20').
              Open

                      $noc = new \Detain\MyAdminSoftaculous\SoftaculousNOC(SOFTACULOUS_USERNAME, SOFTACULOUS_PASSWORD);
              Severity: Minor
              Found in src/activate_softaculous.php by phpmd

              MissingImport

              Since: 2.7.0

              Importing all external classes in a file through use statements makes them clearly visible.

              Example

              function make() {
    return new \stdClass();
}

              Source http://phpmd.org/rules/cleancode.html#MissingImport

              Missing class import via use statement (line '22', column '20').
              Open

                      $noc = new \Detain\MyAdminSoftaculous\SoftaculousNOC(WEBUZO_USERNAME, WEBUZO_PASSWORD);
              Severity: Minor
              Found in src/activate_webuzo.php by phpmd

              MissingImport

              Since: 2.7.0

              Importing all external classes in a file through use statements makes them clearly visible.

              Example

              function make() {
    return new \stdClass();
}

              Source http://phpmd.org/rules/cleancode.html#MissingImport

              Missing class import via use statement (line '18', column '20').
              Open

                      $noc = new \Detain\MyAdminSoftaculous\SoftaculousNOC(WEBUZO_USERNAME, WEBUZO_PASSWORD);
              Severity: Minor
              Found in src/deactivate_webuzo.php by phpmd

              MissingImport

              Since: 2.7.0

              Importing all external classes in a file through use statements makes them clearly visible.

              Example

              function make() {
    return new \stdClass();
}

              Source http://phpmd.org/rules/cleancode.html#MissingImport

              Missing class import via use statement (line '18', column '20').
              Open

                      $noc = new \Detain\MyAdminSoftaculous\SoftaculousNOC(SOFTACULOUS_USERNAME, SOFTACULOUS_PASSWORD);
              Severity: Minor
              Found in src/deactivate_softaculous.php by phpmd

              MissingImport

              Since: 2.7.0

              Importing all external classes in a file through use statements makes them clearly visible.

              Example

              function make() {
    return new \stdClass();
}

              Source http://phpmd.org/rules/cleancode.html#MissingImport

              Severity
              Category
              Status
              Source
              Language