Sign upLogin

detain/myadmin-vestacp-webhosting

View on GitHub
Star
src/Plugin.php

Summary

Maintainability
A
2 hrs
Test Coverage

Method getActivate has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function getActivate(GenericEvent $event)
    {
        if ($event['category'] == get_service_define('WEB_VESTA')) {
            $serviceClass = $event->getSubject();
            myadmin_log(self::$module, 'info', 'VestaCP Activation', __LINE__, __FILE__, self::$module, $serviceClass->getId());
Severity: Minor
Found in src/Plugin.php - About 1 hr to fix

    Function getTerminate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        public static function getTerminate(GenericEvent $event)
    {
        if ($event['category'] == get_service_define('WEB_VESTA')) {
            $serviceClass = $event->getSubject();
            myadmin_log(self::$module, 'info', 'VestaCP Termination', __LINE__, __FILE__, self::$module, $serviceClass->getId());
    Severity: Minor
    Found in src/Plugin.php - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function getActivate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        public static function getActivate(GenericEvent $event)
    {
        if ($event['category'] == get_service_define('WEB_VESTA')) {
            $serviceClass = $event->getSubject();
            myadmin_log(self::$module, 'info', 'VestaCP Activation', __LINE__, __FILE__, self::$module, $serviceClass->getId());
    Severity: Minor
    Found in src/Plugin.php - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Missing class import via use statement (line '126', column '26').
    Open

                $vesta = new \Detain\MyAdminVestaCP\VestaCP($ip, $user, $pass);
    Severity: Minor
    Found in src/Plugin.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '156', column '26').
    Open

                $vesta = new \Detain\MyAdminVestaCP\VestaCP($ip, $user, $pass);
    Severity: Minor
    Found in src/Plugin.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    The 'getTerminate()' method which returns a boolean should be named 'is...()' or 'has...()'
    Open

        public static function getTerminate(GenericEvent $event)
    {
        if ($event['category'] == get_service_define('WEB_VESTA')) {
            $serviceClass = $event->getSubject();
            myadmin_log(self::$module, 'info', 'VestaCP Termination', __LINE__, __FILE__, self::$module, $serviceClass->getId());
    Severity: Minor
    Found in src/Plugin.php by phpmd

    BooleanGetMethodName

    Since: 0.2

    Looks for methods named 'getX()' with 'boolean' as the return type. The convention is to name these methods 'isX()' or 'hasX()'.

    Example

    class Foo {
    /**
     * @return boolean
     */
    public function getFoo() {} // bad
    /**
     * @return bool
     */
    public function isFoo(); // ok
    /**
     * @return boolean
     */
    public function getFoo($bar); // ok, unless checkParameterizedMethods=true
}

    Source https://phpmd.org/rules/naming.html#booleangetmethodname

    There are no issues that match your filters.

    Category
    Status