Sign upLogin

dev-pipeline/devpipeline-core

View on GitHub
Star

Showing 10 of 14 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

def _print_resolvers(arguments):
    del arguments

    for dependency_resolver in sorted(devpipeline_core.DEPENDENCY_RESOLVERS):
        print(
Severity: Major
Found in lib/devpipeline_core/cli_tools.py and 1 other location - About 1 hr to fix
lib/devpipeline_core/cli_tools.py on lines 24..28

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

def _print_executors(arguments):
    del arguments

    for executor in sorted(devpipeline_core.EXECUTOR_TYPES):
        print("{} - {}".format(executor, devpipeline_core.EXECUTOR_TYPES[executor][1]))
Severity: Major
Found in lib/devpipeline_core/cli_tools.py and 1 other location - About 1 hr to fix
lib/devpipeline_core/cli_tools.py on lines 12..19

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 45.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function _process_reverse has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

def _process_reverse(targets, components, tasks):
    to_process = list(targets)
    known_targets = {target: None for target in targets}
    full_dm = calculate_dependencies(components.keys(), components, tasks)
    dep_manager = devpipeline_core.taskqueue.DependencyManager(tasks)
Severity: Minor
Found in lib/devpipeline_core/resolve.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function calculate_dependencies has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

def calculate_dependencies(targets, full_config, tasks):
    dep_manager = devpipeline_core.taskqueue.DependencyManager(tasks)
    to_process, known_targets = _build_target_tasks(targets, tasks)
    missing_components = []
    while to_process:
Severity: Minor
Found in lib/devpipeline_core/resolve.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function build_flex_args_keys has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

def build_flex_args_keys(components):
    """
    Helper function to build a list of options.

    Some tools require require variations of the same options (e.g., cflags
Severity: Minor
Found in lib/devpipeline_core/toolsupport.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _execute_targets has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

def _execute_targets(task_dict, task_queue, config_info, full_config, fail_function):
Severity: Minor
Found in lib/devpipeline_core/command.py - About 35 mins to fix

    Function _sanitize_legacy_depends has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    def _sanitize_legacy_depends(configuration, error_fn):
    for name, component in configuration.items():
        if "depends" in component:
            if not _get_depends_keys(component):
                error_fn("{} uses a deprecated key (depends)".format(name))
    Severity: Minor
    Found in lib/devpipeline_core/sanitizer.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _execute_targets has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    def _execute_targets(task_dict, task_queue, config_info, full_config, fail_function):
    for component_tasks in task_queue:
        for component_task in component_tasks:
            task_heading = "  {} ({})".format(component_task[0], component_task[1])
            config_info.executor.message(task_heading)
    Severity: Minor
    Found in lib/devpipeline_core/command.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _check_implicit_depends has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    def _check_implicit_depends(component, depends_keys, key, error_fn):
    val = component.get(key, raw=True)
    match = _IMPLICIT_PATTERN.search(val)
    if match:
        dep = match.group(1)
    Severity: Minor
    Found in lib/devpipeline_core/sanitizer.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function process_tasks has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    def process_tasks(arguments, tasks, config_fn):
    def _work_fn(targets, full_config):
        task_order = []
        task_dict = {}
        for name, fn in tasks:
    Severity: Minor
    Found in lib/devpipeline_core/command.py - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language